From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 5513@debbugs.gnu.org
Subject: bug#5513: Archives disregard special mode-class
Date: Thu, 04 Feb 2010 21:52:29 +0200 [thread overview]
Message-ID: <87636dhrjm.fsf@mail.jurta.org> (raw)
In-Reply-To: <jwv1vh1t4b1.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 04 Feb 2010 10:22:30 -0500")
>> I think all `view-buffer' calls should respect the property `mode-class',
>> so I moved this code from `view-file' to `view-buffer'. `view-buffer-1'
>> is a new function with the old content of `view-buffer' for the case when
>> some package would prefer to ignore `mode-class' for some reasons.
>
>> I hesitate to install this patch now because it changes the behavior of
>> `view-file' for a non-critical bug.
>
> Indeed, in this form I don't think it's acceptable for `trunk'.
> If you switch the names around, OTOH it should be safe.
I think in the long run the correct behavior of `view-buffer' should be to
check `mode-class'. Instead of switching the behavior after the release,
we could wait and install the final version of `view-buffer' (that checks for
`mode-class') after feature freeze (or install now to the `pending' branch).
--
Juri Linkov
http://www.jurta.org/emacs/
next prev parent reply other threads:[~2010-02-04 19:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 23:27 bug#5513: Archives disregard special mode-class Juri Linkov
2010-02-03 2:21 ` Stefan Monnier
2010-02-04 0:07 ` Juri Linkov
2010-02-04 15:22 ` Stefan Monnier
2010-02-04 19:52 ` Juri Linkov [this message]
2010-02-04 22:16 ` Stefan Monnier
2010-04-18 23:52 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87636dhrjm.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=5513@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.