From: Chong Yidong <cyd@stupidchicken.com>
To: Vivek Dasmohapatra <vivek@etla.org>
Cc: 5526@debbugs.gnu.org
Subject: bug#5526: 23.1; (master) - charset.c possible unwise use of alloca(3)
Date: Sat, 06 Feb 2010 08:27:53 -0500 [thread overview]
Message-ID: <87636ao5nq.fsf@stupidchicken.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1002051402120.26980@octopus.pepperfish.net> (Vivek Dasmohapatra's message of "Fri, 5 Feb 2010 14:05:38 +0000 (GMT)")
Vivek Dasmohapatra <vivek@etla.org> writes:
> There are actually 3 other locations where the same thing happens, and the
> allocated blocks are stored in a linked list which you need to walk and
> free (I believe) if you switch over to using xmalloc instead. The attached
> patch should do the right thing.
Actually, after looking at this further, I think we need to use
SAFE_ALLOCA instead of xmalloc. I've changed the code accordingly.
Thanks for pointing out the additional changes required. (SAFE_ALLOCA
has a bit more overhead, but I don't see a performance problem after
making this change.)
next prev parent reply other threads:[~2010-02-06 13:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 2:55 bug#5526: 23.1; (master) - charset.c possible unwise use of alloca(3) Vivek Dasmohapatra
2010-02-05 4:15 ` Chong Yidong
2010-02-05 14:05 ` Vivek Dasmohapatra
2010-02-06 13:27 ` Chong Yidong [this message]
2010-02-06 18:08 ` Vivek Dasmohapatra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87636ao5nq.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=5526@debbugs.gnu.org \
--cc=vivek@etla.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.