From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#6447: 23.1; revert-buffer in *vc-diff* Date: Sat, 19 Jun 2010 13:36:43 -0400 Message-ID: <87631ekjpw.fsf@stupidchicken.com> References: <871vc3hyl8.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1276970358 17140 80.91.229.12 (19 Jun 2010 17:59:18 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 19 Jun 2010 17:59:18 +0000 (UTC) Cc: Tom Tromey , 6447@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 19 19:59:16 2010 connect(): No such file or directory Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OQ2K2-0008Bx-19 for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Jun 2010 19:59:16 +0200 Original-Received: from localhost ([127.0.0.1]:34341 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OQ2Jz-0003pk-Gh for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Jun 2010 13:59:11 -0400 Original-Received: from [140.186.70.92] (port=47112 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OQ2Jl-0003kr-I7 for bug-gnu-emacs@gnu.org; Sat, 19 Jun 2010 13:59:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OQ2Jf-0006Qh-Kj for bug-gnu-emacs@gnu.org; Sat, 19 Jun 2010 13:58:52 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48994) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OQ2Jf-0006Qb-JF for bug-gnu-emacs@gnu.org; Sat, 19 Jun 2010 13:58:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OQ1yY-0007c2-4u; Sat, 19 Jun 2010 13:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Jun 2010 17:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6447 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6447-submit@debbugs.gnu.org id=B6447.127696901429254 (code B ref 6447); Sat, 19 Jun 2010 17:37:02 +0000 Original-Received: (at 6447) by debbugs.gnu.org; 19 Jun 2010 17:36:54 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OQ1yP-0007bn-7G for submit@debbugs.gnu.org; Sat, 19 Jun 2010 13:36:53 -0400 Original-Received: from pantheon-po23.its.yale.edu ([130.132.50.117]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OQ1yM-0007bi-V7 for 6447@debbugs.gnu.org; Sat, 19 Jun 2010 13:36:51 -0400 Original-Received: from furry (173-14-147-246-NewEngland.hfc.comcastbusiness.net [173.14.147.246]) (authenticated bits=0) by pantheon-po23.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o5JHajZF019729 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 19 Jun 2010 13:36:46 -0400 Original-Received: by furry (Postfix, from userid 1000) id 1CC70C013; Sat, 19 Jun 2010 19:36:44 +0200 (CEST) In-Reply-To: <871vc3hyl8.fsf@mail.jurta.org> (Juri Linkov's message of "Sat, 19 Jun 2010 17:52:47 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 19 Jun 2010 13:37:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:37871 Archived-At: Juri Linkov writes: > Like the command `diff' after calling `diff-mode' sets > `revert-buffer-function' to lambda with its function arguments, > `vc-diff-internal' could do the same: > > === modified file 'lisp/vc/vc.el' > --- lisp/vc/vc.el 2010-06-11 19:09:57 +0000 > +++ lisp/vc/vc.el 2010-06-19 14:51:14 +0000 > @@ -1547,6 +1547,9 @@ (defun vc-diff-internal (async vc-filese > (message "%s" (cdr messages)) > nil) > (diff-mode) > + (set (make-local-variable 'revert-buffer-function) > + `(lambda (ignore-auto noconfirm) > + (vc-diff-internal ,async ',vc-fileset ,rev1 ,rev2 ,verbose))) > ;; Make the *vc-diff* buffer read only, the diff-mode key > ;; bindings are nicer for read only buffers. pcl-cvs does the > ;; same thing. Looks like a fine idea, please go ahead.