all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Karl Fogel <kfogel@red-bean.com>
To: 6444-done@debbugs.gnu.org
Cc: Thierry Volpiatto <thierry.volpiatto@gmail.com>
Subject: bug#6444: Patch applied.
Date: Tue, 13 Jul 2010 18:10:16 -0400	[thread overview]
Message-ID: <87630jdody.fsf@red-bean.com> (raw)
In-Reply-To: <87iq5inqfc.fsf@tux.homenetwork>

I applied the patch.  I didn't include the `if' -> `when' change in this
commit, because it's extraneous to the functional change.  I'll commit
that improvement separately, afterwards.

Thanks!

  $ bzr ci -F log-message.txt
  Committing to: sftp://kfogel@bzr.savannah.gnu.org/srv/bzr/emacs/trunk/
  modified lisp/ChangeLog
  modified lisp/bookmark.el
  Committed revision 100812.
  $ 

=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog	2010-07-13 17:02:27 +0000
+++ lisp/ChangeLog	2010-07-13 22:09:07 +0000
@@ -1,3 +1,9 @@
+2010-07-13  Karl Fogel  <kfogel@red-bean.com>
+
+	* bookmark.el (bookmark-show-annotation): Ensure annotations show,
+	e.g. in Info bookmarks, by using `switch-to-buffer-other-window'.
+	Patch by Thierry Volpiatto (Bug#6444).
+
 2010-07-13  Chong Yidong  <cyd@stupidchicken.com>
 
 	* frame.el (make-frame): Fix typo in 2010-06-30 change (Bug#6625).

=== modified file 'lisp/bookmark.el'
--- lisp/bookmark.el	2010-07-10 18:52:53 +0000
+++ lisp/bookmark.el	2010-07-13 22:05:39 +0000
@@ -1741,7 +1741,7 @@
             ;; (insert (concat "Annotation for bookmark '" bookmark "':\n\n"))
             (insert annotation)
             (goto-char (point-min))
-            (pop-to-buffer old-buf))))))
+            (switch-to-buffer-other-window old-buf))))))
 
 
 (defun bookmark-show-all-annotations ()






      reply	other threads:[~2010-07-13 22:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-17  6:06 bug#6444: 24.0.50; bookmark don't jump to annotation buffer Thierry Volpiatto
2010-07-13 22:10 ` Karl Fogel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87630jdody.fsf@red-bean.com \
    --to=kfogel@red-bean.com \
    --cc=6444-done@debbugs.gnu.org \
    --cc=thierry.volpiatto@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.