From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jim Meyering Newsgroups: gmane.emacs.devel,gmane.comp.lib.gnulib.bugs Subject: Re: Still unable to build trunk Date: Thu, 27 Jan 2011 10:38:27 +0100 Message-ID: <8762tak7os.fsf@meyering.net> References: <87y66fv2d3.fsf@stupidchicken.com> <4D388F7F.20708@swipnet.se> <87r5c7jk5m.fsf@stupidchicken.com> <4D39EF9C.1050804@cs.ucla.edu> <4D3A8666.4070609@cs.ucla.edu> <877hdvd49f.fsf@meyering.net> <83mxmrzhb6.fsf@gnu.org> <4D3C9C5B.8050303@cs.ucla.edu> <83aaiqyxrw.fsf@gnu.org> <4D3DE80E.5030805@cs.ucla.edu> <874o8vpyre.fsf@meyering.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1296121141 8478 80.91.229.12 (27 Jan 2011 09:39:01 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 27 Jan 2011 09:39:01 +0000 (UTC) Cc: Paul Eggert , bug-gnulib@gnu.org, cyd@stupidchicken.com, emacs-devel@gnu.org, Eli Zaretskii , jan.h.d@swipnet.se To: Lennart Borgman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 27 10:38:56 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PiOJY-0000HJ-Ds for ged-emacs-devel@m.gmane.org; Thu, 27 Jan 2011 10:38:54 +0100 Original-Received: from localhost ([127.0.0.1]:46973 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PiOJW-0005hj-HR for ged-emacs-devel@m.gmane.org; Thu, 27 Jan 2011 04:38:50 -0500 Original-Received: from [140.186.70.92] (port=51957 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PiOJK-0003sJ-3g for emacs-devel@gnu.org; Thu, 27 Jan 2011 04:38:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PiOJH-0003w0-6q for emacs-devel@gnu.org; Thu, 27 Jan 2011 04:38:36 -0500 Original-Received: from mx.meyering.net ([82.230.74.64]:50284) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PiOJE-0003v5-Bx; Thu, 27 Jan 2011 04:38:32 -0500 Original-Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id 19A22600EF; Thu, 27 Jan 2011 10:38:28 +0100 (CET) In-Reply-To: <874o8vpyre.fsf@meyering.net> (Jim Meyering's message of "Wed, 26 Jan 2011 14:42:29 +0100") Original-Lines: 62 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135084 gmane.comp.lib.gnulib.bugs:25014 Archived-At: Jim Meyering wrote: > Lennart Borgman wrote: >> I just tried to build on w32 (with the tools I used before) and got >> the error below. Is that expected at the moment? >> >> gcc -I. -c -gdwarf-2 -g3 -DEMACSDEBUG -Ic:/g/include >> -fno-crossjumping -Demacs=1 -DHAVE_CONFIG_H -I../nt/inc -DHAVE_N >> TGUI=1 -DUSE_CRT_DLL=1 -DPURESIZE=5000000 -o oo/i386/print.o print.c >> print.c:53:21: ftoastr.h: No such file or directory >> make[2]: *** [oo/i386/print.o] Error 1 >> make[2]: Leaving directory `C:/emacs-lp/bld/emacs/trunk/src' >> make[1]: *** [bootstrap-temacs] Error 2 >> make[1]: Leaving directory `C:/emacs-lp/bld/emacs/trunk/src' >> make: *** [bootstrap-gmake] Error 2 > > ftoastr.h should be in lib/, so the fix is to > do something like adding -I../lib to CFLAGS as used > when running make in src/ Here's an untested patch to do that, assuming that srcdir==builddir. >From 15399c4cf788f89f82197c69884b2e5886c4f9b3 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 27 Jan 2011 10:36:57 +0100 Subject: [PATCH] fix w32 compilation failure * makefile.w32-in (LOCAL_FLAGS): Add -I../lib, for gnulib-added headers like ftoastr.h. Reported by Lennart Borgman. --- src/ChangeLog | 6 ++++++ src/makefile.w32-in | 2 +- 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/src/ChangeLog b/src/ChangeLog index b864b92..b34d6b3 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,3 +1,9 @@ +2011-01-27 Jim Meyering + + fix w32 compilation failure + * makefile.w32-in (LOCAL_FLAGS): Add -I../lib, for gnulib-added + headers like ftoastr.h. Reported by Lennart Borgman. + 2011-01-26 Stefan Monnier Let the debugger continue to the normal handler (bug#7825). diff --git a/src/makefile.w32-in b/src/makefile.w32-in index 549acf8..8303999 100644 --- a/src/makefile.w32-in +++ b/src/makefile.w32-in @@ -28,7 +28,7 @@ EMACSLOADPATH=$(CURDIR)/../lisp # HAVE_CONFIG_H is required by some generic gnu sources stuck into # the emacs source tree. # -LOCAL_FLAGS = -Demacs=1 -DHAVE_CONFIG_H -I../nt/inc -DHAVE_NTGUI=1 $(EMACS_EXTRA_C_FLAGS) +LOCAL_FLAGS = -Demacs=1 -DHAVE_CONFIG_H -I../lib -I../nt/inc -DHAVE_NTGUI=1 $(EMACS_EXTRA_C_FLAGS) SRC = . EMACS = $(BLD)/emacs.exe -- 1.7.3.5.38.gb312b