From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: bug in copy-directory Date: Sat, 12 Feb 2011 10:01:34 +0100 Message-ID: <8762spd3td.fsf@gmx.de> References: <87ipxaidea.fsf@gmail.com> <87ei7qrdp0.fsf@gmail.com> <87ipx2dayh.fsf@gmx.de> <87y65yyxfu.fsf@gmail.com> <87d3n8xkeq.fsf@gmail.com> <878vxw6r4m.fsf@gmx.de> <87pqr790b0.fsf@gmail.com> <87oc6r7gjc.fsf@gmx.de> <87ipwz8t92.fsf@gmail.com> <878vxt69k7.fsf@stupidchicken.com> <874o8hbc9q.fsf@gmx.de> <87y65txele.fsf@gmail.com> <87tyghxdgx.fsf@gmail.com> <87wrl98adj.fsf@stupidchicken.com> <87k4h7at1c.fsf@gmail.com> <87fwrvkm3y.fsf@gmx.de> <871v3eucjw.fsf@gmail.com> <87tyga86p0.fsf@stupidchicken.com> <8762spspeb.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1297501356 26546 80.91.229.12 (12 Feb 2011 09:02:36 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 12 Feb 2011 09:02:36 +0000 (UTC) Cc: Chong Yidong , emacs-devel@gnu.org To: Thierry Volpiatto Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 12 10:02:31 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PoBMY-0007gT-U0 for ged-emacs-devel@m.gmane.org; Sat, 12 Feb 2011 10:01:55 +0100 Original-Received: from localhost ([127.0.0.1]:41296 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PoBMX-0003q8-S7 for ged-emacs-devel@m.gmane.org; Sat, 12 Feb 2011 04:01:53 -0500 Original-Received: from [140.186.70.92] (port=51063 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PoBMO-0003oQ-Og for emacs-devel@gnu.org; Sat, 12 Feb 2011 04:01:45 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PoBMN-00037P-Fj for emacs-devel@gnu.org; Sat, 12 Feb 2011 04:01:44 -0500 Original-Received: from mailout-de.gmx.net ([213.165.64.23]:58752) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1PoBMN-000356-63 for emacs-devel@gnu.org; Sat, 12 Feb 2011 04:01:43 -0500 Original-Received: (qmail invoked by alias); 12 Feb 2011 09:01:41 -0000 Original-Received: from p57BB8480.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.132.128] by mail.gmx.net (mp065) with SMTP; 12 Feb 2011 10:01:41 +0100 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX19PJokImCJPiu+C2mkmfkbVXgaZ6aV2WkVa39NNeg JKCFPJBSvUiHpz In-Reply-To: <8762spspeb.fsf@gmail.com> (Thierry Volpiatto's message of "Sat, 12 Feb 2011 08:06:20 +0100") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 213.165.64.23 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135935 Archived-At: Thierry Volpiatto writes: > Chong Yidong writes: > >> Thierry Volpiatto writes: >> >>> Michael Albinus writes: >>> >>>>> (defun copy-directory (directory newname &optional keep-time >>>> parents copy-contents-only) >>>> >>>> I'm in favor of this proposal (compared with the recently introduced >>>> `copy-as-subdir'). Thierry's proposal keeps the semantics of >>>> `copy-directory', and the changed semantics are activated by the >>>> optional argument. >>> >>> So when everybody is ok, i can send patch with this modification. >>> Tell me also if copy-contents-only as arg name is ok for you (if you >>> have better idea i take). >> >> This is OK for the trunk. If we go this route, I'd prefer to revert the >> branch to the Emacs 23.2 behavior, since it requires non-local changes >> and is backward incompatible; then we'll make the change for Emacs 24. > ???I would say revert to Emacs 23.2 bug... Thierry's patch, removing the recently introduced `copy-as-subdir', could go into Emacs 23.3 IMHO. The extension `copy-contents-only' shall be applied in the trunk. Best regards, Michael.