From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#12399: 24.2.50; dired-do-touch doesn't recognize empty input in minibuffer Date: Wed, 12 Sep 2012 01:50:35 +0300 Organization: JURTA Message-ID: <87627k41rj.fsf@mail.jurta.org> References: <878vciakcd.fsf@mail.jurta.org> <87k3w01v1y.fsf@altern.org> <87sjao5r1y.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1347404009 9497 80.91.229.3 (11 Sep 2012 22:53:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 11 Sep 2012 22:53:29 +0000 (UTC) Cc: Bastien , 12399@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 12 00:53:32 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TBZKg-0008Ca-SM for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Sep 2012 00:53:26 +0200 Original-Received: from localhost ([::1]:44488 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBZKd-0004yx-DH for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Sep 2012 18:53:23 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53922) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBZKb-0004yr-G4 for bug-gnu-emacs@gnu.org; Tue, 11 Sep 2012 18:53:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TBZKa-0002Zi-Jm for bug-gnu-emacs@gnu.org; Tue, 11 Sep 2012 18:53:21 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45830) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBZKa-0002Ze-G4 for bug-gnu-emacs@gnu.org; Tue, 11 Sep 2012 18:53:20 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TBZLG-0004HB-Gl for bug-gnu-emacs@gnu.org; Tue, 11 Sep 2012 18:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Sep 2012 22:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12399 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12399-submit@debbugs.gnu.org id=B12399.134740401016397 (code B ref 12399); Tue, 11 Sep 2012 22:54:02 +0000 Original-Received: (at 12399) by debbugs.gnu.org; 11 Sep 2012 22:53:30 +0000 Original-Received: from localhost ([127.0.0.1]:55375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBZKj-0004GP-T1 for submit@debbugs.gnu.org; Tue, 11 Sep 2012 18:53:30 -0400 Original-Received: from ps18281.dreamhost.com ([69.163.218.105]:33692 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBZKf-0004GF-8H for 12399@debbugs.gnu.org; Tue, 11 Sep 2012 18:53:26 -0400 Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 83AF2451CCB7; Tue, 11 Sep 2012 15:52:40 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Tue, 11 Sep 2012 16:46:10 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:64168 Archived-At: > There's another way to do that: check (eq val default), since the > returned value will be `eq' to the `default' if the minibuffer was > empty, whereas if it comes from a non-empty minibuffer it will at best > be `equal'. I tried this in the following patch and it works. There is too little space in comments to explain this hack, so I added a bug reference. Old (string-equal new-attribute "") remains as a precaution against possible unexpected changes in `dired-mark-read-string'. === modified file 'lisp/dired-aux.el' --- lisp/dired-aux.el 2012-09-08 14:48:27 +0000 +++ lisp/dired-aux.el 2012-09-11 22:48:01 +0000 @@ -244,7 +244,10 @@ (defun dired-do-chxxx (attribute-name pr (function dired-check-process) (append (list operation program) - (unless (string-equal new-attribute "") + (unless (or (string-equal new-attribute "") + ;; Use `eq' instead of `equal' + ;; to detect empty input (bug#12399). + (eq new-attribute default)) (if (eq op-symbol 'touch) (list "-t" new-attribute) (list new-attribute)))