From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Achim Gratz Newsgroups: gmane.emacs.devel Subject: Re: /srv/bzr/emacs/trunk r110286: Sync Org 7.9.2 from the commit tagged "release_7.9.2" in Org's Git repo. Date: Mon, 01 Oct 2012 18:47:02 +0200 Organization: Linux Private Site Message-ID: <87626uuol5.fsf@Rainer.invalid> References: <87pq5267ew.fsf@bzg.ath.cx> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1349110792 19594 80.91.229.3 (1 Oct 2012 16:59:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 1 Oct 2012 16:59:52 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 01 18:59:57 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TIjLO-0005mC-RL for ged-emacs-devel@m.gmane.org; Mon, 01 Oct 2012 18:59:46 +0200 Original-Received: from localhost ([::1]:49680 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIjAv-0003Sj-UO for ged-emacs-devel@m.gmane.org; Mon, 01 Oct 2012 12:48:57 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:39311) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIjAt-0003SW-Lg for emacs-devel@gnu.org; Mon, 01 Oct 2012 12:48:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TIjAo-0008AH-D3 for emacs-devel@gnu.org; Mon, 01 Oct 2012 12:48:55 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:51390) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIjAo-0008AD-6V for emacs-devel@gnu.org; Mon, 01 Oct 2012 12:48:50 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1TIjAd-0003hR-NB for emacs-devel@gnu.org; Mon, 01 Oct 2012 18:48:39 +0200 Original-Received: from pd9eb3304.dip.t-dialin.net ([217.235.51.4]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 01 Oct 2012 18:48:39 +0200 Original-Received: from Stromeko by pd9eb3304.dip.t-dialin.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 01 Oct 2012 18:48:39 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 46 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: pd9eb3304.dip.t-dialin.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) Cancel-Lock: sha1:0FFI9BMMCOYMtfIwKE6I2mP19ac= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153857 Archived-At: Bastien writes: >> It's weird to see this as a constant (rather than something related to >> the installation prefix), since it won't be correct for many >> installations (but I did not check how it is actually used): This is a generated file in Org and the path generated is related to the installation prefix. Not sure how this should be handled in Emacs. Reminds me: the file local variable that say "version control: never" should also be deleted from that file. >> ;;;###autoload >> (defconst org-odt-data-dir "/usr/share/emacs/etc/org" >> "The location of ODT styles.") > > This is not only weird, this is wrong. I fixed this in Org, > this will be part of the next bugfix sync with Emacs. Huh? How is a defvar any different than a defconst? The problem is not the defconst as such. >> Also, have you considered having a separate org-loaddefs.el, for >> autoloads that are not relevant until org.el is loaded? > > Yes, I can how loaddefs.el could benefit from an org-loaddefs.el. > > I see how I can generate a separate org-loaddefs.el (and we do this > already for people who install Org separately, the file is called > org-install.el) but I don't see how I can prevent Emacs from adding > the same autoloaded functions in loaddefs.el. You change all autoload cookies to some different value like autoload-org. Then you generate org-loaddefs.el using that cookie and when loaddefs.el is generated using the original cookie it comes up empty. The real work there is to decide, for each autoload, whether it belongs into org-loaddefs.el or loaddefs.el. This is decidedly not the same thing that org-install.el does. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Wavetables for the Terratec KOMPLEXER: http://Synth.Stromeko.net/Downloads.html#KomplexerWaves