From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Engster Newsgroups: gmane.emacs.devel Subject: Re: Byte compiler and eval-when-compile Date: Thu, 18 Oct 2012 20:55:57 +0200 Message-ID: <876267zk1u.fsf@engster.org> References: <87a9vn7lhv.fsf@engster.org> <87626b7d02.fsf@engster.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1350586577 17282 80.91.229.3 (18 Oct 2012 18:56:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 18 Oct 2012 18:56:17 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 18 20:56:24 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TOvGZ-0007Th-5b for ged-emacs-devel@m.gmane.org; Thu, 18 Oct 2012 20:56:23 +0200 Original-Received: from localhost ([::1]:39348 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOvGS-0000k8-1d for ged-emacs-devel@m.gmane.org; Thu, 18 Oct 2012 14:56:16 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45753) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOvGP-0000jr-7R for emacs-devel@gnu.org; Thu, 18 Oct 2012 14:56:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOvGN-00067q-Ns for emacs-devel@gnu.org; Thu, 18 Oct 2012 14:56:13 -0400 Original-Received: from randomsample.de ([83.169.19.17]:47704) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOvGN-00063e-AT for emacs-devel@gnu.org; Thu, 18 Oct 2012 14:56:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=randomsample.de; s=a; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=pEKfH2qKskhuw7Eo/VFU1VMQtrwhy6zgOPOFuWje9wY=; b=JX4M1OT6cf6wb8VNe9Jh6NuDtIdz/8ttDnGpjnui2WoRVyi20evLsaINewmuyUmKOz4tPfoXT9pWsQ1H6xpJh8QEZxflajU09VWbTmKZFNYX6o+hjh0nutmGJHC3JMW+; Original-Received: from dslc-082-083-062-221.pools.arcor-ip.net ([82.83.62.221] helo=spaten) by randomsample.de with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1TOvGA-0000U2-JO; Thu, 18 Oct 2012 20:55:59 +0200 In-Reply-To: (Stefan Monnier's message of "Mon, 15 Oct 2012 20:58:27 -0400") User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2.50 (gnu/linux) Mail-Followup-To: Stefan Monnier , emacs-devel@gnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 83.169.19.17 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:154417 Archived-At: Stefan Monnier writes: >>> Actually, it just recovered the smartness I added many years ago and >>> which got broken years ago as well. >> Just to make sure I understand this right: the byte-compiler will now >> bark if you're using functions (instead of just macros and defsubsts) >> from eval-when-compile'd required packages? > > Yes, at least that's the intention: IIRC the implementation is pretty > approximate, so it may very well miss some such functions and complain > about unjustified ones. Could you maybe take a look at the end of eieio.el? I don't understand why the compiler warns that `eieio-update-lisp-imenu-expression' is undefined (he actually always did that, not only since your last change). I'm also not sure what's the fix here - why did you wrap the check for (boundp 'lisp-imenu-generic-expression) in an `eval-when-compile'? [It's not really important, but I'm curious. :-) ] -David