From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@altern.org>
Subject: Re: [PATCH] Add a different prefix for past deadlines in the agenda
 view
Date: Thu, 28 Feb 2013 09:29:19 +0100
Message-ID: <87621chme8.fsf@bzg.ath.cx>
References: <861ucvrbb8.fsf@somewhere.org> <877gmn4s0y.fsf@bzg.ath.cx>
	<87k3ptsvvk.fsf@bzg.ath.cx> <86zjyo97jx.fsf@somewhere.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:56307)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1UAyrl-0006l9-F2
	for emacs-orgmode@gnu.org; Thu, 28 Feb 2013 03:29:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1UAyri-0001F6-DQ
	for emacs-orgmode@gnu.org; Thu, 28 Feb 2013 03:29:25 -0500
Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:59975)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1UAyri-0001EQ-5L
	for emacs-orgmode@gnu.org; Thu, 28 Feb 2013 03:29:22 -0500
Received: by mail-wg0-f42.google.com with SMTP id 12so6088328wgh.1
	for <emacs-orgmode@gnu.org>; Thu, 28 Feb 2013 00:29:21 -0800 (PST)
In-Reply-To: <86zjyo97jx.fsf@somewhere.org> (Sebastien Vauban's message of
	"Thu, 28 Feb 2013 09:17:06 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Sebastien Vauban <public-wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@plane.gmane.org>
Cc: OrgMode ML <emacs-orgmode@gnu.org>

Hi Sébastien,

"Sebastien Vauban"
<wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org> writes:

> Though, one question: why did you change the spacing (and, in fact, the width)
> of the leaders?
>
> -(defcustom org-agenda-scheduled-leaders '("Scheduled: " "Sched.%2dx: ")
> +(defcustom org-agenda-scheduled-leaders '(" Scheduled: " "Sched.%3dx: ")
>    "Text preceding scheduled items in the agenda view.
>
> (...)
>
> -(defcustom org-agenda-deadline-leaders '("Deadline:  " "In %3d d.: ")
> +(defcustom org-agenda-deadline-leaders '("  Deadline: " " In %3d d.: " "%3d d. ago: ")

For the change in "Scheduled:" and "Deadline:" it's because I
think it's cleaner to align them on the right, like the "Sched."
and "In %3d.:" strings.

For the change in the width (from 11 to 12), it's because I
wanted to correctly display "%3d d. ago: ", not %2d d. ago: ",
so that now any string with a warning delay more than 100 will
be correctly displayed.  Before, we allowed 100+ days for the
future deadlines, but not for past scheduled items (i.e. they
were not aligned properly.)

I feel the change is not too intrusive.

Best,

-- 
 Bastien