From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: filenotify.el Date: Wed, 26 Jun 2013 08:40:11 +0200 Message-ID: <8761x12x4k.fsf@gmx.de> References: <87d2ra9z4x.fsf@gmx.de> <1383316.4Bc292dOgY@descartes> <87vc52yq04.fsf@gmx.de> <4199085.Bycd8r9Vun@descartes> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1372228820 8029 80.91.229.3 (26 Jun 2013 06:40:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 26 Jun 2013 06:40:20 +0000 (UTC) Cc: emacs-devel@gnu.org To: =?utf-8?Q?R=C3=BCdiger?= Sonderfeld Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 26 08:40:21 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UrjOu-0007oa-SX for ged-emacs-devel@m.gmane.org; Wed, 26 Jun 2013 08:40:20 +0200 Original-Received: from localhost ([::1]:50432 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrjOu-00010B-I2 for ged-emacs-devel@m.gmane.org; Wed, 26 Jun 2013 02:40:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrjOr-000106-In for emacs-devel@gnu.org; Wed, 26 Jun 2013 02:40:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UrjOq-0000uw-Jg for emacs-devel@gnu.org; Wed, 26 Jun 2013 02:40:17 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:60173) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrjOq-0000ua-AL for emacs-devel@gnu.org; Wed, 26 Jun 2013 02:40:16 -0400 Original-Received: from mailout-de.gmx.net ([10.1.76.16]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0MCvpV-1V0IFp3jpj-009fnL for ; Wed, 26 Jun 2013 08:40:14 +0200 Original-Received: (qmail invoked by alias); 26 Jun 2013 06:40:14 -0000 Original-Received: from p5B2980C1.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [91.41.128.193] by mail.gmx.net (mp016) with SMTP; 26 Jun 2013 08:40:14 +0200 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX182/4t3hf02++rLalntd6EHZDzMSOYxWjXCvDHUNV nHGboRJTgATtWs In-Reply-To: <4199085.Bycd8r9Vun@descartes> (=?utf-8?Q?=22R=C3=BCdiger?= Sonderfeld"'s message of "Wed, 26 Jun 2013 02:45:44 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 212.227.17.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:161073 Archived-At: R=C3=BCdiger Sonderfeld writes: > One minor nitpick I forgot: You should use two hyphens for functions whi= ch=20 > are not meant to be used by the user. Ahh. This is a rather new coding style in Emacs; it didn't even find its way into the Lisp Refefence Manual yet :-) But it's useful; I'll apply. > I guess this should also include `file-notify--handle-event'. Don't know. I'm not decided yet whether to use this function also in Tramp. >> Really? I don't see a serious difference between (featurep 'inotify) and >> (eq file-notify-support 'inotify) > > This would of course only make sense if the support isn't exclusive. OK, so I set it to the used package symbol. But it must be documented clearly, that this is applied for *local* file systems only; Tramp will use a different implementation very likely. Later, when there are several low-level file notification packages linked to Emacs in parallel, we could change `file-notify-support' into a defcustom. The user could decide which of the packages to use. Maybe we shall give it another name for that purpose. >> I believe, that the callback function needs special care from the >> callee. In `auto-revert-notify-handler', I wrap the sensitive code by >> `ignore-errors'. For example. > > But this error couldn't be handled by `ignore-errors' because it happens= =20 > before the callback is called. Or am I misunderstanding you? Where shall this happen? In `file-notify-handle-event'? This function does not depend on a registered file watcher. > Regards > R=C3=BCdiger Best regards, Michael.