From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Kodi Arfer <kodi@arfer.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ox-html: Restore wrongly omitted table attributes under HTML5.
Date: Sun, 30 Jun 2013 00:37:33 +0200 [thread overview]
Message-ID: <8761wwk0gi.fsf@gmail.com> (raw)
In-Reply-To: <51CEF804.8070608@arfer.net> (Kodi Arfer's message of "Sat, 29 Jun 2013 11:06:44 -0400")
Hello,
Kodi Arfer <kodi@arfer.net> writes:
> From edd97671641e28c3e240efe6ea8fa8d77b4b7eae Mon Sep 17 00:00:00 2001
> From: Kodi Arfer <git@arfer.net>
> Date: Sat, 29 Jun 2013 10:43:07 -0400
> Subject: [PATCH] ox-html: Restore wrongly omitted table attributes under
> HTML5.
>
> * lisp/ox-html.el (org-html-table): For HTML5,
> omit :html-table-attributes but not :id or :attr_html.
Thank you for your patch. Could you rebase it against "maint"? I cannot
apply it at the moment.
> + (unless (org-html-html5-p info)
> + (plist-get info :html-table-attributes))
One nitpick. It is more explicit to use:
(and (not (org-html-html5-p info))
(plist-get info :html-table-attributes))
since you are using the returned value.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2013-06-29 22:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-29 15:06 [PATCH] ox-html: Restore wrongly omitted table attributes under HTML5 Kodi Arfer
2013-06-29 22:37 ` Nicolas Goaziou [this message]
2013-06-29 23:30 ` Kodi Arfer
2013-06-30 7:35 ` Nicolas Goaziou
2013-06-30 20:14 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761wwk0gi.fsf@gmail.com \
--to=n.goaziou@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=kodi@arfer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.