From: Juri Linkov <juri@jurta.org>
To: Anders Lindgren <andlind@gmail.com>
Cc: 16035@debbugs.gnu.org
Subject: bug#16035: 24.3.50; Custom isearch broken on trunk (e.g. change-log-mode)
Date: Mon, 16 Dec 2013 22:32:40 +0200 [thread overview]
Message-ID: <8761qoa653.fsf@mail.jurta.org> (raw)
In-Reply-To: <CABr8ebYCrm8pW_sqLYVZgaz0vrsxokjuu7+nkM_cGwN9DfBHZQ@mail.gmail.com> (Anders Lindgren's message of "Mon, 16 Dec 2013 09:13:42 +0100")
> I just found another (minor) detail problem regarding the new isearch
> system.
>
> I sometimes use ESCAPE as the meta key. However, to exit an isearch search,
> pressing the real meta key (Cmd, on my mac) and < work as intended.
> However, the sequence ESCAPE < does not. Emacs simply responds that
> "<escape> < is undefined".
Hopefully, the following patch fixes this in a correct way.
At least, it works in all tests that I tried:
C-s ESC < - exits isearch and goes to the top
C-s ESC c - doesn't exit isearch and toggles case-sensitivity
C-s ESC ESC ESC - cancels isearch
=== modified file 'lisp/isearch.el'
--- lisp/isearch.el 2013-12-06 00:55:20 +0000
+++ lisp/isearch.el 2013-12-16 20:28:12 +0000
@@ -435,8 +435,7 @@ (defvar isearch-mode-map
;; would be simpler to disable the global keymap, and/or have a
;; default local key binding for any key not otherwise bound.
(let ((meta-map (make-sparse-keymap)))
- (define-key map (char-to-string meta-prefix-char) meta-map)
- (define-key map [escape] meta-map))
+ (define-key map (char-to-string meta-prefix-char) meta-map))
;; Several non-printing chars change the searching behavior.
(define-key map "\C-s" 'isearch-repeat-forward)
@@ -453,7 +452,6 @@ (defvar isearch-mode-map
(or (= ?\e meta-prefix-char)
(error "Inconsistency in isearch.el"))
(define-key map "\e\e\e" 'isearch-cancel)
- (define-key map [escape escape escape] 'isearch-cancel)
(define-key map "\C-q" 'isearch-quote-char)
next prev parent reply other threads:[~2013-12-16 20:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 9:38 bug#16035: 24.3.50; Custom isearch broken on trunk (e.g. change-log-mode) Anders Lindgren
2013-12-04 0:14 ` Juri Linkov
2013-12-04 0:18 ` Juri Linkov
2013-12-04 0:37 ` Juri Linkov
2013-12-04 4:31 ` Stefan Monnier
2013-12-04 11:48 ` Anders Lindgren
2013-12-04 17:57 ` Stefan Monnier
2013-12-04 21:49 ` Anders Lindgren
2013-12-05 1:20 ` Juri Linkov
2013-12-05 2:45 ` Stefan Monnier
2013-12-06 0:57 ` Juri Linkov
2013-12-11 0:12 ` Juri Linkov
2013-12-16 8:13 ` Anders Lindgren
2013-12-16 20:32 ` Juri Linkov [this message]
2013-12-17 6:17 ` Anders Lindgren
2013-12-17 19:38 ` Juri Linkov
2013-12-18 8:02 ` Anders Lindgren
2013-12-18 23:22 ` Juri Linkov
2013-12-19 13:35 ` Stefan Monnier
2013-12-19 20:39 ` Juri Linkov
2013-12-05 15:33 ` Anders Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761qoa653.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=16035@debbugs.gnu.org \
--cc=andlind@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.