Problem with org-clock-display

Problem with org-clock-display

[Noah Slater]

[-- Attachment #1: Type: text/plain, Size: 788 bytes --]

I'm having some issues with org-clock-dosplay.

Screenshot here:

https://gist.github.com/nslater/10022848

Note:

- Times are indented like the nodes, meaning they don't line up. (I presume
this is intentional, but I find it annoying. Is there a way to turn it off?)

- Everything is highlighted with yellow. Is this intentional? Can I turn it
off?

- Why are some of the times blue and some white. Can I turn this off?

- Why are some of the "..." bits visible (in blue) and invisible (in white
for the subnodes) and can I turn these off, or hide them consistently?

- Would there be any way to move the black "..." bit meaning "this node can
be expanded" to the very left, where it usually is, and then hide the rest?

- Why can't I edit node names when this is active?

Thanks!

Noah

[-- Attachment #2: Type: text/html, Size: 1224 bytes --]

Re: Problem with org-clock-display

[Bastien]

Hi Noah,

Noah Slater <nslater@tumbolia.org> writes:

> Note:
>
> - Times are indented like the nodes, meaning they don't line up. (I
> presume this is intentional, but I find it annoying. Is there a way
> to turn it off?)

Fixed.

> - Everything is highlighted with yellow. Is this intentional? Can I
> turn it off?

M-x customize-face RET org-clock-display RET

I changed from yellow to gray.

> - Why are some of the times blue and some white. Can I turn this off?

Because the face inherited from the headline face.
I changed it by specified a foreground.

> - Why are some of the "..." bits visible (in blue) and invisible (in
> white for the subnodes) and can I turn these off, or hide them
> consistently?
>
> - Would there be any way to move the black "..." bit meaning "this
> node can be expanded" to the very left, where it usually is, and then
> hide the rest?

The "..." folding indicator is always on the right, not sure what you
mean. 

> - Why can't I edit node names when this is active?

Because the display is temporary and uses overlays.

-- 
 Bastien

Re: Problem with org-clock-display

[Noah Slater]

[-- Attachment #1: Type: text/plain, Size: 3062 bytes --]

Thanks for this!

I've seen your comments on the time cookie thread. But I will pull the
org-clock-display comments here.

So, I have your changes locally, and I have a few comments.

A folded node looks like this:

* Node........................................ 02:10 ...

I was wondering if the "........................................" bit can
be hidden. Is there a font face to customise for this? I find it
distracting, especially with a big list of folded nodes.

The only problem then is: how do I match the times up with the nodes. I
guess this is the problem I was trying to solve with the clock cookies.

One option would be to highlight the time with a new face when the point is
on a node. Not sure about this though.

If the above is possible, then would it be possible to move that "..."
(after the clock total) to the left-hand side, so that it looks like this:

* Node...                                      02:10

i.e. What it normally looks like. Only with a "02:10" on the right hand
side.

The only other thing I'd want to change is the alignment of the times.

So right now, we have:

2d 18:10
7:30
11:32

(For instance.)

It would be great if these could be aligned so that:

- The ":" ran down the middle (single column)
- The hours were zero padded, so it was "07" and not "7"
- There was some padding for days

i.e. If there are no days, you add the space necessary so that the clock
time aligns with other nodes that have days.

Not sure how to calculate this. Perhaps it's possible to calculate the max
clock value before display, and pad everything to the width of that.

One radical alternative to all of the above:

Remove the "..................." stuff. Don't align the times. Just stick
them right after the node text, like a cookie.

As I say: I am more than happy to actually work on the patches necessary to
make these changes


On 17 April 2014 10:22, Bastien <bzg@gnu.org> wrote:

> Hi Noah,
>
> Noah Slater <nslater@tumbolia.org> writes:
>
> > Note:
> >
> > - Times are indented like the nodes, meaning they don't line up. (I
> > presume this is intentional, but I find it annoying. Is there a way
> > to turn it off?)
>
> Fixed.
>
> > - Everything is highlighted with yellow. Is this intentional? Can I
> > turn it off?
>
> M-x customize-face RET org-clock-display RET
>
> I changed from yellow to gray.
>
> > - Why are some of the times blue and some white. Can I turn this off?
>
> Because the face inherited from the headline face.
> I changed it by specified a foreground.
>
> > - Why are some of the "..." bits visible (in blue) and invisible (in
> > white for the subnodes) and can I turn these off, or hide them
> > consistently?
> >
> > - Would there be any way to move the black "..." bit meaning "this
> > node can be expanded" to the very left, where it usually is, and then
> > hide the rest?
>
> The "..." folding indicator is always on the right, not sure what you
> mean.
>
> > - Why can't I edit node names when this is active?
>
> Because the display is temporary and uses overlays.
>
> --
>  Bastien
>

[-- Attachment #2: Type: text/html, Size: 4436 bytes --]

Re: Problem with org-clock-display

[Bastien]

Hi,

Noah Slater <nslater@tumbolia.org> writes:

> I was wondering if the "........................................" bit
> can be hidden. Is there a font face to customise for this? I find it
> distracting, especially with a big list of folded nodes.

Check latest master: I removed the dots.

> The only problem then is: how do I match the times up with the nodes.
> I guess this is the problem I was trying to solve with the clock
> cookies.
>
> One option would be to highlight the time with a new face when the
> point is on a node. Not sure about this though.
>
> If the above is possible, then would it be possible to move that
> "..." (after the clock total) to the left-hand side, so that it looks
> like this:
>
> * Node...                                      02:10

This cannot be easily achieved, if at all. 

> The only other thing I'd want to change is the alignment of the
> times.
>
> So right now, we have:
>
> 2d 18:10
> 7:30
> 11:32

From master, this should be aligned correctly now.

> (For instance.)
>
> It would be great if these could be aligned so that:
>
> - The ":" ran down the middle (single column)
> - The hours were zero padded, so it was "07" and not "7"

Well, not possible.

> - There was some padding for days
>
> i.e. If there are no days, you add the space necessary so that the
> clock time aligns with other nodes that have days.

Done.

> As I say: I am more than happy to actually work on the patches
> necessary to make these changes

Yep -- please submit a patch for other changes you would like to
make.  Read http://orgmode.org/worg/org-contribute.html twice to
format the patches correctly :)

-- 
 Bastien

Re: Problem with org-clock-display

[Noah Slater]

[-- Attachment #1: Type: text/plain, Size: 2406 bytes --]

Huh, this is *very* cool. Thank you.

Now I need to solve the problem of being able to tie the node to the
clock-display. (If there's a big list, then it's hard to visually match
them.)

I think I recall a minor mode that highlighted the current line your point
is on. That would fix it. But then, it would be nice if that worked with my
mouse too.

Any ideas?

I think unless there's an obvious way to solve this, that it might actually
make sense to have the "......." bit visible by default, and provide an
option to turn it off for people who don't mind the way it looks.

Thoughts?


On 17 April 2014 13:12, Bastien <bzg@gnu.org> wrote:

> Hi,
>
> Noah Slater <nslater@tumbolia.org> writes:
>
> > I was wondering if the "........................................" bit
> > can be hidden. Is there a font face to customise for this? I find it
> > distracting, especially with a big list of folded nodes.
>
> Check latest master: I removed the dots.
>
> > The only problem then is: how do I match the times up with the nodes.
> > I guess this is the problem I was trying to solve with the clock
> > cookies.
> >
> > One option would be to highlight the time with a new face when the
> > point is on a node. Not sure about this though.
> >
> > If the above is possible, then would it be possible to move that
> > "..." (after the clock total) to the left-hand side, so that it looks
> > like this:
> >
> > * Node...                                      02:10
>
> This cannot be easily achieved, if at all.
>
> > The only other thing I'd want to change is the alignment of the
> > times.
> >
> > So right now, we have:
> >
> > 2d 18:10
> > 7:30
> > 11:32
>
> From master, this should be aligned correctly now.
>
> > (For instance.)
> >
> > It would be great if these could be aligned so that:
> >
> > - The ":" ran down the middle (single column)
> > - The hours were zero padded, so it was "07" and not "7"
>
> Well, not possible.
>
> > - There was some padding for days
> >
> > i.e. If there are no days, you add the space necessary so that the
> > clock time aligns with other nodes that have days.
>
> Done.
>
> > As I say: I am more than happy to actually work on the patches
> > necessary to make these changes
>
> Yep -- please submit a patch for other changes you would like to
> make.  Read http://orgmode.org/worg/org-contribute.html twice to
> format the patches correctly :)
>
> --
>  Bastien
>

[-- Attachment #2: Type: text/html, Size: 3503 bytes --]

Re: Problem with org-clock-display

[Bastien]

Noah Slater <nslater@tumbolia.org> writes:

> Now I need to solve the problem of being able to tie the node to the
> clock-display. (If there's a big list, then it's hard to visually
> match them.)

I'm not really sure what you mean by "tie the node to the clock-display".

> I think I recall a minor mode that highlighted the current line your
> point is on.

M-x hl-line-mode RET

> That would fix it. But then, it would be nice if that
> worked with my mouse too.
>
> Any ideas?
>
> I think unless there's an obvious way to solve this, that it might
> actually make sense to have the "......." bit visible by default, and
> provide an option to turn it off for people who don't mind the way it
> looks.
>
> Thoughts?

The dots have been removed, so really not sure what we are talking
about :)  But if you want to make the folding three dots "..." be
displayed differently, that's hard -- and I don't think it's worth
the time.

-- 
 Bastien

Re: Problem with org-clock-display

[Noah Slater]

[-- Attachment #1: Type: text/plain, Size: 2741 bytes --]

Ah, sorry.

So what I mean is, if you have a long list of lines like this:

* A                                                            5:10 ...
* B                                                            8:40 ...
* C                                                            2:50 ...

Then it is a bit tricky to see what time is clocked for, say, B.

It is easy above because there are only three nodes. But if you have 20
nodes, it gets tricky.

So my thinking was that previously the "...................." bits helped
to guide your eye across. But I am not so sure, you know. Because if you
have 20 of those in a row, it's not really helping much.

* A ........................................................... 5:10 ...
* B ........................................................... 8:40 ...
* C ........................................................... 2:50 ...

Again, this is easy when you just have three. But you have 20 in a row,
it's hard to follow.

So my idea was to use something like ln-line (thanks!) to show you where
you are. Then I can just navigate around the nodes, and it is obvious what
time matches up to what node.

Bit I'm wondering if you have any better ideas.

Or, given the readability problems, it makes sense to display the
"..............." bits by default. (Though I am not sure that they are
actually much more readable.)

This is one of the reasons I suggested an alternative approach: do not
align the times to the right at all, just stick them right next to the node
titles, like so:

* Apple 5:10 ...
* Bananas 8:40 ...
* Carrots 2:50 ...

As you can see, the times wont line up then, but matching them to the node
titles is easy.


On 17 April 2014 13:43, Bastien <bzg@gnu.org> wrote:

> Noah Slater <nslater@tumbolia.org> writes:
>
> > Now I need to solve the problem of being able to tie the node to the
> > clock-display. (If there's a big list, then it's hard to visually
> > match them.)
>
> I'm not really sure what you mean by "tie the node to the clock-display".
>
> > I think I recall a minor mode that highlighted the current line your
> > point is on.
>
> M-x hl-line-mode RET
>
> > That would fix it. But then, it would be nice if that
> > worked with my mouse too.
> >
> > Any ideas?
> >
> > I think unless there's an obvious way to solve this, that it might
> > actually make sense to have the "......." bit visible by default, and
> > provide an option to turn it off for people who don't mind the way it
> > looks.
> >
> > Thoughts?
>
> The dots have been removed, so really not sure what we are talking
> about :)  But if you want to make the folding three dots "..." be
> displayed differently, that's hard -- and I don't think it's worth
> the time.
>
> --
>  Bastien
>

[-- Attachment #2: Type: text/html, Size: 3836 bytes --]

Re: Problem with org-clock-display

[Bastien]

Noah Slater <nslater@tumbolia.org> writes:

> As you can see, the times wont line up then, but matching them to the
> node titles is easy.

Mhhh... I see.

Maybe we can use the background color for the whole headline?

But for now I'd like to let the dust settle on the current
implementation so that others can chime in if they have the same
problem.

-- 
 Bastien

Re: Problem with org-clock-display

[Sebastien Vauban]

Hello Bastien,

Bastien wrote:
> Noah Slater <nslater-OPLt7ZjDFOFg9hUCZPvPmw@public.gmane.org> writes:
>>
>> - Times are indented like the nodes, meaning they don't line up. (I
>> presume this is intentional, but I find it annoying. Is there a way
>> to turn it off?)
>
> Fixed.
>
>> - Everything is highlighted with yellow. Is this intentional? Can I
>> turn it off?
>
> M-x customize-face RET org-clock-display RET
>
> I changed from yellow to gray.
>
>> - Why are some of the times blue and some white. Can I turn this off?
>
> Because the face inherited from the headline face.
> I changed it by specified a foreground.

I tested your changes with this ECM file:

--8<---------------cut here---------------start------------->8---
#+TITLE:     Example of Tasks
#+LANGUAGE:  en

* Marketing
  :PROPERTIES:
  :CATEGORY: Marketing
  :END:

** STRT Hire PR firm                                                    :phone:
   DEADLINE: <2014-03-12 Wed>
   :LOGBOOK:
   CLOCK: [2013-02-05 Tue 09:00]--[2013-02-05 Tue 10:11] =>  1:11
   - State "TODO"        ->  "STRT"       [2013-02-05 Tue 17:48]
   - State "TODO"        ->  "STRT"       [2013-08-19 Mon 15:16]
   :END:

*** Call Laura about PR firm                                            :phone:

*** Interview PR firm candidates

* Work
  :PROPERTIES:
  :CATEGORY: Work
  :END:

** TODO Update database to latest version
   SCHEDULED: <2014-03-13 Thu>

* Personal
  :PROPERTIES:
  :CATEGORY: Personal
  :END:

** DONE Read "Getting Things Done"
   :LOGBOOK:
   - State "TODO"        ->  "DONE"       [2014-01-06 Mon 15:10]
   :END:

** WAIT Mail package to Susan
   :LOGBOOK:
   - State "TODO"        ->  "STRT"       [2013-07-24 Wed 15:45]
   CLOCK: [2013-07-24 Wed 15:45]--[2013-07-24 Wed 17:28] =>  1:43
   CLOCK: [2013-08-12 Mon 11:56]--[2013-08-12 Mon 12:12] =>  0:16
   - State "STRT"        ->  "DONE"       [2013-08-12 Mon 12:12]
   - State "DONE"        ->  "TODO"       [2013-09-27 Fri 10:23]
   - State "TODO"        ->  "WAIT"       [2013-11-15 Fri 12:00]
   :END:

--8<---------------cut here---------------end--------------->8---

and the Leuven theme (in the current trunk of the "to be" Emacs 24.4).

See (on http://screencast.com/t/hkFpXhQG) that there are 2 weirdnesses:

- The last letter of the headline text gets its height amplified when
  there is a following "time display".

- The ":" of the "phone" tag gets temporarily overlaid with an "m".

Best regards,
  Seb

-- 
Sebastien Vauban

Re: Problem with org-clock-display

[Bastien]

Hi Sébastien,

should be fixed, thanks!

-- 
 Bastien

Re: Problem with org-clock-display

[Sebastien Vauban]

Hi Bastien,

Bastien wrote:
> should be fixed, thanks!

Almost, but not really.

See http://screencast.com/t/fmR5TJfa what happens to the size of the
titles, when the overlay is applied or removed.

Also, I did prefer (unlike Noah) when there were no "reading dots". Is
there a way to remove them, or at least to get them in a very light
gray, for example?

Best regards,
  Seb

-- 
Sebastien Vauban

Re: Problem with org-clock-display

[Noah Slater]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

On 18 April 2014 17:03, Sebastien Vauban <sva-news@mygooglest.com> wrote:

>
> Also, I did prefer (unlike Noah) when there were no "reading dots". Is
> there a way to remove them, or at least to get them in a very light
> gray, for example?


They are completely removed for me.

[-- Attachment #2: Type: text/html, Size: 746 bytes --]

Re: Problem with org-clock-display

[Bastien]

Hi,

Sebastien Vauban <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
writes:

> See http://screencast.com/t/fmR5TJfa what happens to the size of the
> titles, when the overlay is applied or removed.

Fixed, although I think this bug was present before I tweaked this
function.

> Also, I did prefer (unlike Noah) when there were no "reading dots". Is
> there a way to remove them, or at least to get them in a very light
> gray, for example?

I reinstalled the dots (different ones) with a shadow background:
having the dots is good to match the headline visually.

-- 
 Bastien

Re: Problem with org-clock-display

[Noah Slater]

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

Can the dots use a custom face? I'd like to customise the colour (by
perhaps turning it off).


On 19 April 2014 07:18, Bastien <bzg@gnu.org> wrote:

>
>
> Hi,
>
> Sebastien Vauban <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
> writes:
>
> > See http://screencast.com/t/fmR5TJfa what happens to the size of the
> > titles, when the overlay is applied or removed.
>
> Fixed, although I think this bug was present before I tweaked this
> function.
>
> > Also, I did prefer (unlike Noah) when there were no "reading dots". Is
> > there a way to remove them, or at least to get them in a very light
> > gray, for example?
>
> I reinstalled the dots (different ones) with a shadow background:
> having the dots is good to match the headline visually.
>
> --
>  Bastien
>
>
>

[-- Attachment #2: Type: text/html, Size: 1389 bytes --]

Re: Problem with org-clock-display

[Bastien]

Noah Slater <nslater@tumbolia.org> writes:

> Can the dots use a custom face? I'd like to customise the colour (by
> perhaps turning it off).

It uses the shadow face.

M-x customize-face RET shadow RET

-- 
 Bastien

Re: Problem with org-clock-display

[Noah Slater]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

Hmm. Okay. It might be a good idea to have org-clock-shadow or something,
so it can be customised separately. I might want to hide the dots, but
still have shadow as a useable face.


On 20 April 2014 11:02, Bastien <bzg@gnu.org> wrote:

> Noah Slater <nslater@tumbolia.org> writes:
>
> > Can the dots use a custom face? I'd like to customise the colour (by
> > perhaps turning it off).
>
> It uses the shadow face.
>
> M-x customize-face RET shadow RET
>
> --
>  Bastien
>

[-- Attachment #2: Type: text/html, Size: 937 bytes --]

Re: Problem with org-clock-display

[Bastien]

Noah Slater <nslater@tumbolia.org> writes:

> Hmm. Okay. It might be a good idea to have org-clock-shadow or
> something, so it can be customised separately. I might want to hide
> the dots, but still have shadow as a useable face.

Let me resist to this for a while: I'm not fan a having a separate
face for everything in Org, especially transient display.  Also,
maybe you can try adapting shadow and see where this face is used
elsewhere?

-- 
 Bastien

Re: Problem with org-clock-display

[Sebastien Vauban]

Hi Bastien,

Bastien wrote:
> Noah Slater <nslater-OPLt7ZjDFOFg9hUCZPvPmw@public.gmane.org> writes:
>
>> Hmm. Okay. It might be a good idea to have org-clock-shadow or
>> something, so it can be customised separately. I might want to hide
>> the dots, but still have shadow as a useable face.
>
> Let me resist to this for a while: I'm not fan a having a separate
> face for everything in Org, especially transient display.  Also,
> maybe you can try adapting shadow and see where this face is used
> elsewhere?

If you don't like to add a face, then I'd also favor the possibility to
turn off the display of dots -- without having to touch the shadow face.

Best regards,
  Seb

-- 
Sebastien Vauban

Re: Problem with org-clock-display

[Bastien]

Hi Sébastien,

Sebastien Vauban <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
writes:

> If you don't like to add a face, then I'd also favor the possibility to
> turn off the display of dots -- without having to touch the shadow face.

Well, I don't want to add a face for the same reasons I don't want
adding an option: we are really in the bikeshed zone here, let's just
live with it.

-- 
 Bastien

Re: Problem with org-clock-display

[Noah Slater]

[-- Attachment #1: Type: text/plain, Size: 643 bytes --]

I guess Sebastien's point is that without a custom face, the only way to
turn the dots off is to set the shadow face to be hidden. But that could
have unintended side-effects. So if there's no custom face, then there
should be a config so that people can turn it off without having to deal
with those side-effects.


On 20 April 2014 14:30, Bastien <bzg@gnu.org> wrote:

>
>
> Hi Sébastien,
>
> Sebastien Vauban <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
> writes:
>
> > If you don't like to add a face, then I'd also favor the possibility to
> > turn off the display of dots -- without having to touch the shadow face

Re: Problem with org-clock-display

[Bastien]

Hi Noah,

Noah Slater <nslater@tumbolia.org> writes:

> I guess Sebastien's point is that without a custom face, the only way to
> turn the dots off is to set the shadow face to be hidden. But that could
> have unintended side-effects. So if there's no custom face, then there
> should be a config so that people can turn it off without having to deal
> with those side-effects.

My point is that all this is not important, I'd rather have us all
focused on more pressing issues.  Hope you both understand,

-- 
 Bastien