From: Dima Kogan <dima@secretsauce.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 19117@debbugs.gnu.org
Subject: bug#19117: 25.0.50; emacs on x11 chooses different fonts for the same face sometimes
Date: Sat, 27 Dec 2014 01:17:26 -0800 [thread overview]
Message-ID: <8761cxigri.fsf@secretsauce.net> (raw)
In-Reply-To: <jwvoaqpj0v8.fsf-monnier+emacsbugs@gnu.org>
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> IIUC if `scalable-fonts-allowed' is set to nil, that's what should happen.
This was a VERY useful comment. I do not touch scalable-fonts-allowed,
so it should be the default (i.e. nil), meaning that I should already be
disallowing these fonts. Looking at it deeper I see that the font list
is obtained by xfont_list_pattern() in xfont.c. This is an XListFonts()
call, with emacs then filtering the resulting list in various ways.
I see XListFonts() return consistent results, but the post-filtering of
the list is inconsistent. Specifically, the inconsistent piece is
exactly the scalable_fonts_allowed check in xfont_list_pattern():
https://github.com/emacs-mirror/emacs/blob/162660c3639a68a7b71439bdd713d54f940274b8/src/xfont.c#L416
When we get here, scalable_fonts_allowed is sometimes non-nil, which is
the direct cause of my problem. Forcefully removing that check and
always assuming that it IS nil makes this bug go away.
I haven't verified this yet, but presumably scalable_fonts_allowed is
getting set to t in realize_basic_faces() in xfaces.c:
https://github.com/emacs-mirror/emacs/blob/162660c3639a68a7b71439bdd713d54f940274b8/src/xfaces.c#L5236
Any comment on that? That bit of code was there since 2001, so
presumably it's reasonable. Anybody know more?
next prev parent reply other threads:[~2014-12-27 9:17 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 6:13 bug#19117: 25.0.50; emacs on x11 chooses different fonts for the same face sometimes Dima Kogan
2014-11-20 16:10 ` Eli Zaretskii
2014-12-07 7:28 ` Dima Kogan
2014-12-07 16:12 ` Eli Zaretskii
2014-12-17 5:36 ` Dima Kogan
2014-12-17 6:57 ` Dima Kogan
2014-12-18 16:24 ` Eli Zaretskii
2014-12-20 8:08 ` Jan Djärv
2014-12-19 15:28 ` Dmitry Antipov
2014-12-19 22:46 ` Dima Kogan
2014-12-22 8:01 ` Dmitry Antipov
2014-12-22 8:28 ` Jan Djärv
2014-12-26 19:43 ` Dima Kogan
2014-12-27 2:17 ` Stefan Monnier
2014-12-27 9:17 ` Dima Kogan [this message]
2014-12-30 9:44 ` Dima Kogan
2014-12-30 16:57 ` Stefan Monnier
2014-12-30 18:33 ` Dima Kogan
2014-12-30 20:05 ` Eli Zaretskii
2014-12-31 4:06 ` Dima Kogan
2015-01-02 9:43 ` Eli Zaretskii
2015-01-02 21:07 ` Dima Kogan
2015-02-02 8:10 ` Dima Kogan
2015-02-03 17:53 ` Stefan Monnier
2015-02-05 2:41 ` handa
2015-02-15 13:47 ` K. Handa
2015-02-05 15:08 ` Jan D.
2015-02-05 20:41 ` Dima Kogan
2015-02-07 7:24 ` Jan D.
2015-02-07 7:59 ` Jan D.
2015-02-07 8:28 ` Dima Kogan
2015-02-09 14:58 ` Jan D.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761cxigri.fsf@secretsauce.net \
--to=dima@secretsauce.net \
--cc=19117@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.