From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Sergio Durigan Junior Newsgroups: gmane.emacs.bugs Subject: bug#19678: [PATCH] EUDC does not support BBDB 3.x Date: Mon, 26 Jan 2015 17:47:17 -0500 Message-ID: <8761btjh1m.fsf@sergiodj.net> References: <87mw57hhrd.fsf@sergiodj.net> <87lhkpjrg3.fsf@sergiodj.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1422312506 26580 80.91.229.3 (26 Jan 2015 22:48:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 26 Jan 2015 22:48:26 +0000 (UTC) Cc: 19678@debbugs.gnu.org To: Thomas Fitzsimmons Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 26 23:48:19 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YFsS8-0004V1-0Z for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Jan 2015 23:48:16 +0100 Original-Received: from localhost ([::1]:44436 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFsS7-0005KB-EY for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Jan 2015 17:48:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFsRz-0005F2-Ku for bug-gnu-emacs@gnu.org; Mon, 26 Jan 2015 17:48:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFsRu-0007UN-E5 for bug-gnu-emacs@gnu.org; Mon, 26 Jan 2015 17:48:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38673) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFsRu-0007UH-3P for bug-gnu-emacs@gnu.org; Mon, 26 Jan 2015 17:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YFsRt-00013O-Ln for bug-gnu-emacs@gnu.org; Mon, 26 Jan 2015 17:48:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Sergio Durigan Junior Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Jan 2015 22:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19678 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 19678-submit@debbugs.gnu.org id=B19678.14223124424000 (code B ref 19678); Mon, 26 Jan 2015 22:48:01 +0000 Original-Received: (at 19678) by debbugs.gnu.org; 26 Jan 2015 22:47:22 +0000 Original-Received: from localhost ([127.0.0.1]:57365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YFsRF-00012R-Mx for submit@debbugs.gnu.org; Mon, 26 Jan 2015 17:47:22 -0500 Original-Received: from kwanyin.sergiodj.net ([176.31.208.32]:42074) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YFsRD-00012J-Og for 19678@debbugs.gnu.org; Mon, 26 Jan 2015 17:47:21 -0500 X-URL: http://blog.sergiodj.net In-Reply-To: (Thomas Fitzsimmons's message of "Mon, 26 Jan 2015 17:21:22 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98771 Archived-At: On Monday, January 26 2015, Thomas Fitzsimmons wrote: >> Almost there... The patch doesn't work as-is because >> 'eudc-bbdb-current-return-attributes' is set to '(firstname lastname >> mail) for me when eudc-bbdb-format-record-as-result is called. It means >> that, in the while loop, it will try to call eq/memq against 'mail, and >> it fails. > > Hmm, I thought those get converted; in any case, I wasn't seeing that > problem. Do you have any customizations of the relevant variables? Do > you have my latest EUDC/LDAP changes from master tip? I am using git HEAD to test and develop, so I think I do have your changes. As for my customizations, I'm almost sure they're the reason for me seeing the errors. What I have here is: (eudc-protocol-set 'eudc-inline-expansion-format '("%s %s <%s>" firstname name mail) 'bbdb) (eudc-protocol-set 'eudc-inline-query-format '((mail) (firstname) (lastname) (firstname lastname) (aka)) 'bbdb) > Can we step back a bit and make sure we're doing the same tests? BBDB > 2.x is tricky because it is provided by the distro, in my case Fedora. > Let's focus on testing BBDB 3.x so that I can replicate the exact same > issue that you're seeing. > > Can you revert our patch, then: > > 1) Checkout and build Emacs revision > 03a20dc9519616359bfa1b77fd4b31e1963c8bd4 from > git://git.savannah.gnu.org/emacs.git > > This revision has a bunch of my EUDC/LDAP updates in it. I'm buying an even newer revision from git, FWIW. > 2) Download > http://download.savannah.gnu.org/releases/bbdb/bbdb-3.1.2.tar.gz > > 3) Untar and build the ELPA package: > export EMACS=/src/emacs > ./configure && make elpa > unset EMACS > > 4) In the emacs src directory: > mkdir test-home > > 5) HOME=`pwd`/test-home ./emacs -Q > > 6) M-x package-install-file > > bbdb-3.1.2.tar (the one built in step 3) > > 7) M-x bbdb-create > > Name: Test User > Network Address: test@gnu.org > > 8) C-x s > > to save .bbdb > > 9) M-: (eval-after-load "message" > '(define-key message-mode-map (kbd "TAB") 'eudc-expand-inline)) > > 10) M-: (setq debug-on-error 't) > > 11) C-x m > > 12) Tes[TAB] > > (no server, bbdb protocol) > > Without my patch, I get: > > Debugger entered--Lisp error: (void-function bbdb-record-net) > (bbdb-record-net record) > eval((bbdb-record-net record)) > > eudc-bbdb-format-record-as-result(["Test" "User" nil nil nil nil nil > ("test@gnu.org") ((creation-date . "2015-01-26 21:56:26 +0000") > (timestamp . "2015-01-26 21:56:26 +0000")) ["Test User" "User, Test" > nil ("test@gnu.org") nil #]]) > > mapcar(eudc-bbdb-format-record-as-result (["Test" "User" nil nil nil > nil nil ("test@gnu.org") ((creation-date . "2015-01-26 21:56:26 > +0000") (timestamp . "2015-01-26 21:56:26 +0000")) ["Test User" "User, > Test" nil ("test@gnu.org") nil #]])) > > eudc-bbdb-query-internal(((firstname . "Tes")) (firstname lastname > net)) > > eudc-query(((firstname . "Tes")) (firstname lastname net)) > eudc-expand-inline() > funcall-interactively(eudc-expand-inline) > call-interactively(eudc-expand-inline nil nil) > command-execute(eudc-expand-inline) > > With my patch (0001-EUDC-Support-BBDB-3.patch), it works. eudc-query > gets called with 'net, not 'mail. > > If that works for you, can you try to replicate the other error you're > seeing when my patch is applied, in this same minimal environment, and > paste the testing steps and the backtrace you get? If you insist, I can do this test later (unfortunately I will be very busy these next days). Meanwhile, if you could check that my configuration is what triggers the failure, I'd appreciate. Also, IMHO, the final patch makes sense to me, even if there are still other issues to be fix on EUDC. Thank you, -- Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/