From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Engster Newsgroups: gmane.emacs.devel Subject: Re: Noisy byte compilation on master Date: Wed, 18 Feb 2015 18:53:33 +0100 Message-ID: <8761aznm1u.fsf@engster.org> References: <83egq9ipkn.fsf@gnu.org> <858uggchvx.fsf@stephe-leake.org> <87twz379z2.fsf@engster.org> <87twyndv53.fsf@engster.org> <87bnktpnns.fsf@engster.org> <87vbj1nj4z.fsf@engster.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1424282047 30458 80.91.229.3 (18 Feb 2015 17:54:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 18 Feb 2015 17:54:07 +0000 (UTC) Cc: "Eric M. Ludlam" , Stephen Leake , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 18 18:53:59 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YO8ot-0005Ay-U4 for ged-emacs-devel@m.gmane.org; Wed, 18 Feb 2015 18:53:56 +0100 Original-Received: from localhost ([::1]:52080 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YO8ot-0000IV-BX for ged-emacs-devel@m.gmane.org; Wed, 18 Feb 2015 12:53:55 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43328) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YO8oq-0000IN-9I for emacs-devel@gnu.org; Wed, 18 Feb 2015 12:53:53 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YO8om-00012r-DS for emacs-devel@gnu.org; Wed, 18 Feb 2015 12:53:52 -0500 Original-Received: from randomsample.de ([5.45.97.173]:51934) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YO8oh-0000zf-Ah; Wed, 18 Feb 2015 12:53:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=randomsample.de; s=a; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=3m1+TMgh7Q6q3Z6kPBuWrkdA7Q2K67fpjfn9mh2RlaE=; b=BaRVQMCf1BR8dL2wR8I+yQYKaMMG1RxuNC/EenQOgdWg6rxJwkpHGzxC1tfYfVuqrFqC4fkeAeGYncmqS8b++G0vSaeDH3zZbpEzpmzMhH/Zk+n+X7TQC++L5KU2YKBN; Original-Received: from ip4d149227.dynamic.kabel-deutschland.de ([77.20.146.39] helo=spaten) by randomsample.de with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YO8od-0007Wx-RF; Wed, 18 Feb 2015 18:53:40 +0100 In-Reply-To: (Stefan Monnier's message of "Tue, 17 Feb 2015 18:06:27 -0500") User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.4 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 5.45.97.173 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183262 Archived-At: Stefan Monnier writes: >>> Or you could use a macro which either drops the name argument or passes >>> it depending on the version of EIEIO with which it's compiled. >> I would still have to rewrite the constructor calls, right? > > Yes, but it should be a slightly simpler rewrite (no need to find&remove > the name string). The real work is finding the constructor calls and making sure the string isn't actually used for anything (which we'll have to do anyway, as the string is not saved in Emacs25 unless explicitly set with eieio-object-set-name-string). I really do not want to clutter the code with some macro before every constructor all. That would needlessly also end up in Emacs proper through merging, and it would eventually have to be removed again when we stop supporting Emacs24. I'm actually a bit confused, as I thought we agreed that EIEIO should not emit a warning when the string is provided, at least not during run-time. I could live with those warnings during byte-compilation, as I would just shush those as long as we support Emacs24. -David