From: Michael Heerdegen <michael_heerdegen@web.de>
To: Tassilo Horn <tsdh@gnu.org>
Cc: 20141@debbugs.gnu.org, Thierry Volpiatto <thierry.volpiatto@gmail.com>
Subject: bug#20141: 24.4.91; Helm is broken after last changes in eieio
Date: Thu, 19 Mar 2015 09:10:22 +0100 [thread overview]
Message-ID: <87619xwgpd.fsf@web.de> (raw)
In-Reply-To: <87lhitwj2r.fsf@web.de> (Michael Heerdegen's message of "Thu, 19 Mar 2015 08:19:08 +0100")
Michael Heerdegen <michael_heerdegen@web.de> writes:
> (defclass helm-source ()
> ((name
> :initarg :name
> :initform nil
> (header-name
> :initarg :header-name)))
>
> "Main interface to define helm sources."
> :abstract t)
>
> (eieio-class-slots 'helm-source)
>
> Until today it returned (name)
Why is there "header-name" missing in the return value, btw? Sorry if
this is a dumb question, I don't know eieio much.
> , now, you get
>
> ([cl-struct-cl-slot-descriptor name nil t nil])
Let me add that it breaks this code in helm:
--8<---------------cut here---------------start------------->8---
(defun helm--create-source (object)
"[INTERNAL] Build a helm source from OBJECT.
Where OBJECT is an instance of an eieio class."
(cl-loop for s in (object-slots object)
for slot-val = (slot-value object s)
when slot-val
collect (cons s (unless (eq t slot-val) slot-val))))
--8<---------------cut here---------------end--------------->8---
`slot-value' barks that the second arg is not a symbol.
next prev parent reply other threads:[~2015-03-19 8:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 5:17 bug#20141: 24.4.91; Helm is broken after last changes in eieio Thierry Volpiatto
2015-03-19 6:05 ` Ivan Shmakov
2015-03-19 6:12 ` Thierry Volpiatto
2015-03-19 7:20 ` Ivan Shmakov
2015-03-19 6:11 ` Thierry Volpiatto
2015-03-19 6:53 ` Tassilo Horn
2015-03-19 7:19 ` Michael Heerdegen
2015-03-19 8:10 ` Michael Heerdegen [this message]
2015-03-19 14:20 ` Stefan Monnier
2015-03-19 15:46 ` Tassilo Horn
2015-03-19 19:22 ` Stefan Monnier
2015-03-19 18:37 ` Thierry Volpiatto
2015-03-19 20:00 ` Stefan Monnier
2015-03-19 6:55 ` Tassilo Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87619xwgpd.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=20141@debbugs.gnu.org \
--cc=thierry.volpiatto@gmail.com \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.