From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: nljlistbox2@gmail.com (N. Jackson) Newsgroups: gmane.emacs.bugs Subject: bug#20182: 24.4.91; [GTK3] Vertical scroll bar is "indented" from right edge of frame Date: Tue, 24 Mar 2015 17:39:47 -0300 Message-ID: <87619qnn8s.fsf@moondust.localdomain> References: <87h9tbwnfo.fsf@moondust.localdomain> <55106F6C.7010900@gmx.at> <874mpbwglg.fsf@moondust.localdomain> <55108A2C.1010608@gmx.at> <551141A6.3050404@gmx.at> <73119439-0C7D-4A2E-BB1E-4D4B0E95E080@swipnet.se> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1427229693 11741 80.91.229.3 (24 Mar 2015 20:41:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 24 Mar 2015 20:41:33 +0000 (UTC) Cc: 20182@debbugs.gnu.org To: "Jan D." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 24 21:41:21 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YaVdP-0002ie-6S for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Mar 2015 21:41:11 +0100 Original-Received: from localhost ([::1]:34463 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaVdO-0007Zz-HK for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Mar 2015 16:41:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34385) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaVdK-0007Yh-0O for bug-gnu-emacs@gnu.org; Tue, 24 Mar 2015 16:41:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YaVdG-00046W-Qi for bug-gnu-emacs@gnu.org; Tue, 24 Mar 2015 16:41:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45522) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaVdG-00046I-O3 for bug-gnu-emacs@gnu.org; Tue, 24 Mar 2015 16:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YaVdF-0000bz-T2 for bug-gnu-emacs@gnu.org; Tue, 24 Mar 2015 16:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: nljlistbox2@gmail.com (N. Jackson) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Mar 2015 20:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20182 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20182-submit@debbugs.gnu.org id=B20182.14272296072283 (code B ref 20182); Tue, 24 Mar 2015 20:41:01 +0000 Original-Received: (at 20182) by debbugs.gnu.org; 24 Mar 2015 20:40:07 +0000 Original-Received: from localhost ([127.0.0.1]:35298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YaVcM-0000ak-1I for submit@debbugs.gnu.org; Tue, 24 Mar 2015 16:40:06 -0400 Original-Received: from mail-qg0-f51.google.com ([209.85.192.51]:35787) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YaVcI-0000aA-Br for 20182@debbugs.gnu.org; Tue, 24 Mar 2015 16:40:03 -0400 Original-Received: by qgf74 with SMTP id 74so8429320qgf.2 for <20182@debbugs.gnu.org>; Tue, 24 Mar 2015 13:39:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=eDrGzktPl37LN1BP2wArjNj0LKwdB0qjYuJ6D6YeptE=; b=JCJXdw0RtGW32JCwLb4IqvoHUKcElwmXieC7guPOpO7MTi/lFMCH7Rq2q0myf1QUQo KO9rlkewmZ8HfRakhDptcojE3a0VhPPcv6wUBqsC0PrQLY/tIIIT5a69xk3qJmujZt2g eWVUeW2MFQWyuxl7QINTnBQ0KHB5ZscEhJqXMxcuyW+f8GZhuhgtrLoGc2q3PekmyXkb 0NffOdD/h2KKIt/Pxv5L1LMB/Cf5SDIbbH9HDHHi7OZG0OprqPqMfT3TDq2ceuHHJj3n kgWwxoj1S3Yt0/3hQA0h7bxXgplxF9j2cd8o4VaRMFOH/GCL4hUnwO5tfVMAXNFWZSDi NIbg== X-Received: by 10.55.23.195 with SMTP id 64mr12938754qkx.76.1427229595874; Tue, 24 Mar 2015 13:39:55 -0700 (PDT) Original-Received: from moondust.localdomain.nodomain.none (blk-7-145-248.eastlink.ca. [71.7.145.248]) by mx.google.com with ESMTPSA id 206sm188975qhy.1.2015.03.24.13.39.53 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Mar 2015 13:39:54 -0700 (PDT) In-Reply-To: <73119439-0C7D-4A2E-BB1E-4D4B0E95E080@swipnet.se> (Jan D.'s message of "Tue, 24 Mar 2015 17:16:45 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.91 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100898 Archived-At: At 13:16 -0300 on Tuesday 2015-03-24, Jan D. wrote: >> 24 mar 2015 kl. 11:51 skrev martin rudalics : >> >> > 16 was the hardcoded width for Gtk2. >> >> Does that mean gtk_widget_style_get is broken for Gtk2? > > It means that the width it returns is 16. > >> >> > You can #ifdef it. >> >> Like >> >> #if (! GTK_CHECK_VERSION (3, 0, 0) >> if (w < 16) w = 16; >> #endif >> > > Yes, or > #ifndef HAVE_GTK3 > ... > > Jan D. Of course, if gtk_widget_style_get() only returns 16 when the GDK version is not GDK3, then this line if (w < 16) w = 16; in update_theme_scrollbar_width() of gtkutil.c does nothing when the GDK version is not GDK3. Since we don't need this adjustment with GDK3 (with which gtk_widget_style_get() returns the correct value from the toolkit), I replaced the offending line with #ifndef HAVE_GTK3 /* if (w < 16) w = 16; */ eassert (w == 16); #endif and this seems to fix the bug for me. (Of course, removing the offending line altogether has the same effect.) I don't have a GTK2 system to test on, though. Note: The badness is somehow encoded in my desktop file as well, so to see that the fix was working I had to rename my desktop file or run with emacs --no-desktop.