From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Malakhovski Subject: Re: [PATCH v2 0/9] mail, clock and calc changes Date: Wed, 04 Nov 2015 11:59:50 +0000 Message-ID: <87611im0uh.fsf@yin.lan> References: <1446581747-1960-1-git-send-email-oxij@oxij.org> <87d1vqvvx8.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44637) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtwjM-0004YB-TI for emacs-orgmode@gnu.org; Wed, 04 Nov 2015 06:59:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtwjJ-0004Oc-NZ for emacs-orgmode@gnu.org; Wed, 04 Nov 2015 06:59:56 -0500 Received: from tricoro.koumakan.jp ([195.154.188.176]:55393) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtwjJ-0004OU-IB for emacs-orgmode@gnu.org; Wed, 04 Nov 2015 06:59:53 -0500 In-Reply-To: <87d1vqvvx8.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Aaron Ecay , emacs-orgmode@gnu.org Hi. Aaron Ecay writes: > Thanks for the patches! They look good to me. I sent a few minor > comments about code style. I didn=E2=80=99t review the 8th patch (ob-cal= c: add > more API, documentation and examples so that it can be used in tables) > because I didn=E2=80=99t feel familiar enough with the calc API to be use= ful. Thanks for the comments! > Do you want somebody to apply the tinychange patches already? Or do you > want to wait until your assignment is processed and apply them yourself? > (IMO patch 4 could also be a TINYCHANGE, since it is only code movement > with no actual changes). I'm fine either way, including patch 4. If somebody merges those, I'll just resend the rest when I fix the pieces you pointed to. Cheers, Jan