From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.bugs Subject: bug#15746: Fix committed to master. Date: Sun, 08 Nov 2015 14:27:33 -0500 Message-ID: <87611cnvfe.fsf@red-bean.com> References: Reply-To: Karl Fogel NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1447010903 18739 80.91.229.3 (8 Nov 2015 19:28:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 8 Nov 2015 19:28:23 +0000 (UTC) To: 15746-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 08 20:28:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZvVdL-0000vP-UM for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Nov 2015 20:28:12 +0100 Original-Received: from localhost ([::1]:48604 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvVdL-0007O5-3X for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Nov 2015 14:28:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51296) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvVdH-0007Nx-Lx for bug-gnu-emacs@gnu.org; Sun, 08 Nov 2015 14:28:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZvVdC-0005fM-M7 for bug-gnu-emacs@gnu.org; Sun, 08 Nov 2015 14:28:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38901) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvVdC-0005fG-Im for bug-gnu-emacs@gnu.org; Sun, 08 Nov 2015 14:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZvVdC-0003Yp-AD for bug-gnu-emacs@gnu.org; Sun, 08 Nov 2015 14:28:02 -0500 In-Reply-To: Resent-From: Karl Fogel Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Nov 2015 19:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 15746 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 15746@debbugs.gnu.org, kfogel@red-bean.com, sdl.web@gmail.com Original-Received: via spool by 15746-done@debbugs.gnu.org id=D15746.144701088013675 (code D ref 15746); Sun, 08 Nov 2015 19:28:01 +0000 Original-Received: (at 15746-done) by debbugs.gnu.org; 8 Nov 2015 19:28:00 +0000 Original-Received: from localhost ([127.0.0.1]:57840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZvVd9-0003YU-Kd for submit@debbugs.gnu.org; Sun, 08 Nov 2015 14:27:59 -0500 Original-Received: from mail-yk0-f180.google.com ([209.85.160.180]:33881) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZvVcp-0003Y0-9w for 15746-done@debbugs.gnu.org; Sun, 08 Nov 2015 14:27:57 -0500 Original-Received: by ykfs79 with SMTP id s79so5912417ykf.1 for <15746-done@debbugs.gnu.org>; Sun, 08 Nov 2015 11:27:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:reply-to:date:message-id:mime-version :content-type; bh=YgSxLVEX/kQ30ZEI17W0djPMpOprRp8dxlGh9LygjQM=; b=u/ZBXGHPUptx6cDJrciPUtHBvk8pyxRV9wwXGZ8ijlinq7YMJSgAeaBMKNNqY4hSaV /v3VlwvjOJR2CuwThjo7aZl+SDOfOPyMYk4bm0WjqMDYbT7/Xw/8y0c+H/CyFk+/9jNn bY22WNzH3B64pA5YG/E2jzoVZoz2zzJwwD5TzM0qxVKsdJf7pRRTXKYheR7Y68bynlFb p7wNjz3FhWiMe/aHyuo6B9OvOVklJv7V7bpUbngWnoIsfnZ4Ijj7ein2Z3eQhpYmbtds BJ1Y8hFEXiESba/rah1NyOB2/mSmDRP/xRYQ0Av6pHtaM38H4OSujsTCLJRU+BP9sjCj 0EPg== X-Received: by 10.13.238.4 with SMTP id x4mr20051982ywe.344.1447010858865; Sun, 08 Nov 2015 11:27:38 -0800 (PST) Original-Received: from klen ([64.94.31.206]) by smtp.gmail.com with ESMTPSA id v127sm9905751ywd.53.2015.11.08.11.27.37 for <15746-done@debbugs.gnu.org> (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Nov 2015 11:27:38 -0800 (PST) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108582 Archived-At: I've pushed a fix to master for this (commit 3812e17978). Essentially it takes Drew's suggestion. I left "C-x r m" as `bookmark-set', with the same behavior it has now, and "C-x r M" sets a bookmark but errors if it would overwrite an existing bookmark of the same name. I didn't go with Stefan's suggestion of using RET RET instead of RET, because you can't habituate to it. You don't necessarily know in advance whether you're setting a new bookmark or updating an existing bookmark, so you can't predict whether you will need to hit RET or RET RET. Better to offer two different commands, and those people who want one style all the time can just use the appropriate command all the time. Comments and further discussion welcome, of course. Thanks, Leo, for raising this issue, and thanks Drew and Stefan for helping think things through in the bug ticket.