all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Karl Fogel <kfogel@red-bean.com>
To: 15746-done@debbugs.gnu.org
Subject: bug#15746: Fix committed to master.
Date: Sun, 08 Nov 2015 14:27:33 -0500	[thread overview]
Message-ID: <87611cnvfe.fsf@red-bean.com> (raw)
In-Reply-To: <m1a9hsrbth.fsf@gmail.com>

I've pushed a fix to master for this (commit 3812e17978).

Essentially it takes Drew's suggestion.  I left "C-x r m" as `bookmark-set', with the same behavior it has now, and "C-x r M" sets a bookmark but errors if it would overwrite an existing bookmark of the same name.

I didn't go with Stefan's suggestion of using RET RET instead of RET, because you can't habituate to it.  You don't necessarily know in advance whether you're setting a new bookmark or updating an existing bookmark, so you can't predict whether you will need to hit RET or RET RET.  Better to offer two different commands, and those people who want one style all the time can just use the appropriate command all the time.

Comments and further discussion welcome, of course.  Thanks, Leo, for raising this issue, and thanks Drew and Stefan for helping think things through in the bug ticket.





      parent reply	other threads:[~2015-11-08 19:27 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-29  3:32 bug#15746: 24.3; [PATCH] bookmark should confirm when overwrite Leo Liu
2013-10-29 14:20 ` Drew Adams
2013-10-29 18:24 ` Karl Fogel
2013-10-29 20:09   ` Drew Adams
2013-10-29 20:51     ` Karl Fogel
2013-10-29 22:16       ` Drew Adams
2013-10-30  4:31         ` Karl Fogel
2013-10-30 14:07           ` Drew Adams
2013-10-30  2:11     ` Stefan Monnier
2013-10-30  2:35       ` Drew Adams
2013-10-30  2:56       ` Leo Liu
2013-10-30  3:14         ` Stefan Monnier
2013-10-30  3:36           ` Leo Liu
2013-10-30  3:57             ` Stefan Monnier
2013-10-30 14:07           ` Drew Adams
2013-10-30 18:17             ` Stefan Monnier
2013-10-30  1:28   ` Leo Liu
2013-10-30  2:26   ` Drew Adams
2015-11-08 19:27 ` Karl Fogel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87611cnvfe.fsf@red-bean.com \
    --to=kfogel@red-bean.com \
    --cc=15746-done@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.