From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#22333: 24.5; EWW downloads invalid compressed tar-files Date: Thu, 04 Feb 2016 15:59:12 +1100 Message-ID: <8760y52hr3.fsf@gnus.org> References: <8760z3zrxs.fsf@inigo.katxi.org> <83vb73nt4m.fsf@gnu.org> <87io3356z8.fsf@inigo.katxi.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1454562024 32712 80.91.229.3 (4 Feb 2016 05:00:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 4 Feb 2016 05:00:24 +0000 (UTC) Cc: Andreas Schwab , 22333@debbugs.gnu.org To: =?UTF-8?Q?I=C3=B1igo?= Serna Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Feb 04 06:00:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aRC1b-0008Al-VH for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Feb 2016 06:00:12 +0100 Original-Received: from localhost ([::1]:39596 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRC1b-00065q-4s for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Feb 2016 00:00:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRC1X-00063X-Hn for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2016 00:00:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRC1T-0001OZ-Gl for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2016 00:00:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50113) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRC1T-0001Nf-DE for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2016 00:00:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aRC1S-0005wy-PX for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2016 00:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Feb 2016 05:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22333 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22333-submit@debbugs.gnu.org id=B22333.145456198322776 (code B ref 22333); Thu, 04 Feb 2016 05:00:02 +0000 Original-Received: (at 22333) by debbugs.gnu.org; 4 Feb 2016 04:59:43 +0000 Original-Received: from localhost ([127.0.0.1]:58702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRC19-0005vI-Gs for submit@debbugs.gnu.org; Wed, 03 Feb 2016 23:59:43 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:37145) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRC17-0005v8-4Q for 22333@debbugs.gnu.org; Wed, 03 Feb 2016 23:59:41 -0500 Original-Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aRC0k-0007WI-3R; Thu, 04 Feb 2016 05:59:18 +0100 In-Reply-To: <87io3356z8.fsf@inigo.katxi.org> ("=?UTF-8?Q?I=C3=B1igo?= Serna"'s message of "Sat, 09 Jan 2016 12:26:35 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.90 (gnu/linux) X-MailScanner-ID: 1aRC0k-0007WI-3R MailScanner-NULL-Check: 1455166758.94787@ajTjptRogXC3m0CtNNsSJQ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:112377 Archived-At: Iņigo Serna writes: > `eww-download-callback` (called by `url-retrieve`) should remove those headers > after download is finished and before buffer is saved to disk. > > A simple fix could be to add (excuse my poor elisp skills): > > (goto-char (point-min)) > (search-forward-regexp "^$") > (forward-line) > (delete-region (point-min) (point)) > > before '(write-file file)' in `eww-download-callback`. This function looks like this in emacs-25: (defun eww-download-callback (status url) (unless (plist-get status :error) (let* ((obj (url-generic-parse-url url)) (path (car (url-path-and-query obj))) (file (eww-make-unique-file-name (eww-decode-url-file-name (file-name-nondirectory path)) eww-download-directory))) (goto-char (point-min)) (re-search-forward "\r?\n\r?\n") (write-region (point) (point-max) file) (message "Saved %s" file)))) So it looks like this has already been fixed. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no