From: Lars Ingebrigtsen <larsi@gnus.org>
To: Jun Hao <jun_hao@aol.com>
Cc: 22824@debbugs.gnu.org
Subject: bug#22824: Use smtpmail-smtp-user if auth-source-search doesn't return user field
Date: Wed, 02 Mar 2016 16:58:34 +0000 [thread overview]
Message-ID: <8760x4stol.fsf@gnus.org> (raw)
In-Reply-To: <m2si09f19c.fsf@aol.com> (Jun Hao's message of "Wed, 02 Mar 2016 21:51:23 +0800")
Jun Hao <jun_hao@aol.com> writes:
> Please review this patch. I didn't find existing function to do the
> conversion so write a simple helper function to do it. Tested with slash
> and Chinese char in label, account and password field.
Looks good, I think...
[...]
> * auth-source.el (auth-source-macos-keychain-search-items): Handle
> keychain output correctly when has special char. (Bug#22824)
>
> Copyright-paperwork-exempt: yes
[...]
> + (defun* decode-octal-string (string)
The name here should be "auth-source-", though.
And the patch is longer than what we can accept without a copyright
assignment. Would you be willing to sign such a thing?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2016-03-02 16:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-27 7:52 bug#22824: Use smtpmail-smtp-user if auth-source-search doesn't return user field Jun Hao
2016-02-28 5:32 ` Lars Ingebrigtsen
2016-02-28 9:07 ` Jun Hao
2016-02-29 2:22 ` Lars Ingebrigtsen
[not found] ` <m2si09f19c.fsf@aol.com>
2016-03-02 16:58 ` Lars Ingebrigtsen [this message]
[not found] ` <m2k2ljfyuj.fsf@aol.com>
2016-03-03 16:54 ` Lars Ingebrigtsen
2016-03-03 16:59 ` Glenn Morris
[not found] ` <m2mvqegwtu.fsf@aol.com>
[not found] ` <m2bn5d7fjw.fsf@aol.com>
2016-04-24 12:37 ` Lars Magne Ingebrigtsen
2016-04-24 12:43 ` Lars Magne Ingebrigtsen
2016-04-25 14:41 ` Jun Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760x4stol.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=22824@debbugs.gnu.org \
--cc=jun_hao@aol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.