Re: Crappyness of Emacs Version 24.5.1 defadvice

[Michael Heerdegen <michael_heerdegen@web.de>]

Rémi Vanicat <vanicat@debian.org> writes:

>   (defun my-describe-mode-before-advice (oldfun &optional buffer)
>     "my documentation"
>     (delete-other-windows)
>     (apply oldfun buffer))
>
>   (advice-add 'describe-mode :around #'my-describe-mode-before-advice)
>
> Or better with a before advice:
>
>   (defun my-describe-mode-before-advice (&optional buffer)
>     "my documentation"
>     (delete-other-windows))
>
>   (advice-add 'describe-mode :before #'my-desccribe-mode-before-advice)

No need to repeat the argument list of the original function if you
don't use the arguments in the body:

(defun my-describe-mode-before-advice (&rest _ignore)
   "my documentation"
   (delete-other-windows))


Michael.