From mboxrd@z Thu Jan 1 00:00:00 1970 From: Renato Ferreira Subject: [PATCH] org-agenda.el Correct :inherit on org-agenda-fontify-priorities Date: Fri, 04 Nov 2016 08:06:00 -0200 Message-ID: <8760o3k19z.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46903) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2bNe-0004Ao-Vb for emacs-orgmode@gnu.org; Fri, 04 Nov 2016 06:05:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2bNW-0002Lw-J2 for emacs-orgmode@gnu.org; Fri, 04 Nov 2016 06:05:50 -0400 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:34891) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c2bNW-0002K6-Ci for emacs-orgmode@gnu.org; Fri, 04 Nov 2016 06:05:42 -0400 Received: by mail-qk0-x241.google.com with SMTP id n204so5361177qke.2 for ; Fri, 04 Nov 2016 03:05:41 -0700 (PDT) Received: from note (179-96-150-135.life.com.br. [179.96.150.135]) by smtp.gmail.com with ESMTPSA id e33sm643049qtb.42.2016.11.04.03.05.38 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 04 Nov 2016 03:05:39 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org When using: (setq org-agenda-fontify-priorities 'cookies) (setq org-priority-faces '((65 . "#FF9393") (66 . "#CC9393") (67 . "#AC7373") (68 . "#7C4343"))) (org-agenda-fontify-priorities) generates an (:inherit nil ...) face alist, which ultimately (i can't trace specifically where) causes a lot of: "Invalid face reference: nil" "Invalid face attribute :inherit nil" when generating the agenda buffer (when it contains tasks with priorities). This issue has been present since 8.3 (and earlier i believe), i've always patched locally but now i'm using melpa so it would be great if someone could verify and merge this. Thanks a lot, Renato Ferreira PATCH: --- org-agenda.el Correct :inherit on org-agenda-fontify-priorities * Fixes "Invalid face attribute/reference" errors --- lisp/org-agenda.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index 7ee721a..68e82cb 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -3837,11 +3837,11 @@ FILTER-ALIST is an alist of filters we need to apply when ov 'face (let ((special-face (cond ((org-face-from-face-or-color - 'priority nil + 'priority 'org-priority (cdr (assoc p org-priority-faces)))) ((and (listp org-agenda-fontify-priorities) (org-face-from-face-or-color - 'priority nil + 'priority 'org-priority (cdr (assoc p org-agenda-fontify-priorities))))) ((equal p l) 'italic) ((equal p h) 'bold)))) --