From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: Patches for Emacs 25.2 Date: Mon, 07 Nov 2016 11:31:42 +0100 Message-ID: <8760nzfunl.fsf@gmx.de> References: <877f96t9oc.fsf@gmx.de> <837f96xgp5.fsf@gnu.org> <87zim2rtck.fsf@gmx.de> <9181f38b-8d6c-c61e-90b0-d44a9e048c9e@gmail.com> <87wph6qd1d.fsf@gmx.de> <831szexb54.fsf@gnu.org> <83shrtx5dv.fsf@gnu.org> <752ec49c-da5b-bf86-e31d-294c362c04cb@gmail.com> <877f95deig.fsf@gmx.de> <6f656e32-a44c-f874-3290-f47b8828078e@yandex.ru> <87oa1r64vg.fsf@gmx.de> <2d749ac6-636b-14f2-e5a9-dcc0e9ba7541@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1478514768 9694 195.159.176.226 (7 Nov 2016 10:32:48 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 7 Nov 2016 10:32:48 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Eli Zaretskii , Nikolay Kudryavtsev , emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 07 11:32:43 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c3hDz-00084r-0j for ged-emacs-devel@m.gmane.org; Mon, 07 Nov 2016 11:32:23 +0100 Original-Received: from localhost ([::1]:52822 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3hE2-0003YJ-1S for ged-emacs-devel@m.gmane.org; Mon, 07 Nov 2016 05:32:26 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3hDT-0003Y0-SR for emacs-devel@gnu.org; Mon, 07 Nov 2016 05:31:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3hDT-0008CQ-4E for emacs-devel@gnu.org; Mon, 07 Nov 2016 05:31:51 -0500 Original-Received: from mout.gmx.net ([212.227.17.22]:58253) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c3hDN-0008Bg-DN; Mon, 07 Nov 2016 05:31:45 -0500 Original-Received: from detlef.gmx.de ([87.146.53.66]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0M2ojS-1cwDbl0C6Y-00sbRf; Mon, 07 Nov 2016 11:31:43 +0100 In-Reply-To: <2d749ac6-636b-14f2-e5a9-dcc0e9ba7541@yandex.ru> (Dmitry Gutov's message of "Mon, 7 Nov 2016 11:36:22 +0200") X-Provags-ID: V03:K0:dSGMoUnhUy9tOfR2VHtwmzbbziKLQIOItgoWP7QSvke1ZNwphTO P9YdgijEv/OPVz+3XjLPUeOkAdBvRTOhfnvcy0z2O5zYF2jUa3XCUogJeX6USYWXiTQTVW2 BETLIdmgVoAB/tJIlvW3C6ur2XnQ5Zma7B8BVbhJ3RxSiSUMiulhHFEwx5653u7qQTZXocH OuKH7vWKSH/sVK4zo5ROg== X-UI-Out-Filterresults: notjunk:1;V01:K0:5/l6giWAtX8=:G3pq9w2qwspd4taf/ESYyW QO3zk2bwY9Y3iBxXXi1YQBt+n+08IPiSRHqqO5ZGDs7jZwtm6/kj4VczKFOThomhhrBo488gH fsaZrACGcXc5gtDBu6hf3beA36Goza5BV93F094gUCds/DLYNRR3rvP35bH/5wTmwyCsZDgJk axV/oN3OCBC2tFx+3/uctuaJa5GCzA+Z/hyV9xvb4h2es80mQXw7HcbcLsJVD6d6XFgjwQz/P nSmWzrZ6QzrwpBxyU3RqecOA3trFpgoABYXQEIW6zdXkTpGCzYS6G+8SKjZI/pEjUGoMSbeEC d+xCXypupwlGIjXVq1C5m/EA5GjMKIkcnQ+2znzN+Lqo19XZMzen0FAbIyaw8avjJJmrOM/yT wjSmziQv1rwkJsOrCZy6XFD+2HgSTY/JmhKNrfBf+H+9p2se5cVgx2XTXVC1MFCadHiPIIC/q rfjVVwl91DMWdzfmY5gMXgtp3gJVq3X0fbDTd6WZVPBabmKEuY4AhDLVLfapkoDpqMAlnuAZC XwjEocg/VWjTzNjW/ijmm/R7AyhMSQxSNqBx0BtiAnfKRlnBAEsJOPW2QdDkcRTwJdE3V4bW8 O+a9SyBmqqcg5nfywzCSFEc2aLfWPjyxzVy7/t/ghi5/y3iiQuKgqaFl8hoxuV6cNp3g6DnRF LN+ijdrNej6cfXx3PvdltLxokNefunQ8D8kI84pBcWxjLsyIDJVlmiqiUMRwDd299+dHFv1Bs DcaAKlXRAvvvnU+LO6tNwzF4LFaDd+YN/uq5BrY77ouhGcHbJNsWpv1DR7hvsiH4bznV3zPa X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209240 Archived-At: Dmitry Gutov writes: > On 07.11.2016 11:01, Michael Albinus wrote: > >>> Can't we move the (file-remote-p ... 'localname) call to the first >>> hunk here? Then the patch will only change one place, and we get rid >>> of the added `or' here. >> >> I let it to Nikolay. > > Not sure I understand. The patch for the emacs-25 branch is proposed by Nikolay. >> However, given that this construct >> >> (or (file-remote-p FILE 'localname) FILE) >> >> happens several times in the lisp sources, I wonder whether we shall >> give it an own defmacro or defsubst (in master, of course). > > I have no strong opinion either way, but your commit in master fixing > this problem does not have this construct. Sure. It was a rather general comment, given that we find this construct under .../emacs/lisp for at least 11 times, and under .../elpa 4 times. Best regards, Michael.