* bug#25446: 26.0.50; [PATCH] Fix undeclared FOO-mode-{syntax,abbrev}-table warnings
@ 2017-01-14 7:05 npostavs
2017-01-20 1:31 ` npostavs
0 siblings, 1 reply; 2+ messages in thread
From: npostavs @ 2017-01-14 7:05 UTC (permalink / raw
To: 25446
[-- Attachment #1: Type: text/plain, Size: 185 bytes --]
Tags: patch
Severity: minor
Since [1: 8db7b65] there have been a lot of "reference to free variable
`FOO-mode-syntax-table'" and `FOO-mode-abbtrev-table' warnings during
compilation.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 1220 bytes --]
From bcbe6eb903d3874c3cc1fe9ab48b8a2dc9e00abb Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@gmail.com>
Date: Sat, 14 Jan 2017 01:47:52 -0500
Subject: [PATCH v1] Fix undeclared syntax- and abbrev- table warnings
* lisp/emacs-lisp/derived.el (define-derived-mode): Unconditionally
defvar the syntax and abbrev tables so that the compiler will know that
they are dynamically bound variables.
---
lisp/emacs-lisp/derived.el | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lisp/emacs-lisp/derived.el b/lisp/emacs-lisp/derived.el
index 762c762..fffe972 100644
--- a/lisp/emacs-lisp/derived.el
+++ b/lisp/emacs-lisp/derived.el
@@ -216,6 +216,7 @@ define-derived-mode
(purecopy ,(format "Keymap for `%s'." child))))
,(if declare-syntax
`(progn
+ (defvar ,syntax)
(unless (boundp ',syntax)
(put ',syntax 'definition-name ',child)
(defvar ,syntax (make-syntax-table)))
@@ -224,6 +225,7 @@ define-derived-mode
(purecopy ,(format "Syntax table for `%s'." child))))))
,(if declare-abbrev
`(progn
+ (defvar ,abbrev)
(unless (boundp ',abbrev)
(put ',abbrev 'definition-name ',child)
(defvar ,abbrev
--
2.9.3
[-- Attachment #3: Type: text/plain, Size: 108 bytes --]
1: 2016-12-12 20:03:20 -0500 8db7b65d66f01e90a05cc9f11c67667233d84ca0
Minor fix for define-derived-mode
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#25446: 26.0.50; [PATCH] Fix undeclared FOO-mode-{syntax,abbrev}-table warnings
2017-01-14 7:05 bug#25446: 26.0.50; [PATCH] Fix undeclared FOO-mode-{syntax,abbrev}-table warnings npostavs
@ 2017-01-20 1:31 ` npostavs
0 siblings, 0 replies; 2+ messages in thread
From: npostavs @ 2017-01-20 1:31 UTC (permalink / raw
To: 25446
tags 25446 fixed
close 25446
quit
Pushed to master [1: 296a23d].
1: 2017-01-18 20:37:31 -0500 296a23db17617508ff7fa384b19aee0220df3261
Fix free var FOO-mode-{syntax,abbrev}-table warnings
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-20 1:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-14 7:05 bug#25446: 26.0.50; [PATCH] Fix undeclared FOO-mode-{syntax,abbrev}-table warnings npostavs
2017-01-20 1:31 ` npostavs
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.