From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Edward John Steere Newsgroups: gmane.emacs.devel Subject: Re: CEDET Merge Date: Sat, 28 Jan 2017 11:23:38 +0200 Message-ID: <8760kzo7vp.fsf@gmail.com> References: <87r348ul9n.fsf@gmail.com> <87lgugm2qg.fsf@gmail.com> <87inpelu8i.fsf@gmail.com> <837f5uajlk.fsf@gnu.org> <87a8aqlqz8.fsf@gmail.com> <8360leahxr.fsf@gnu.org> <8760lelq68.fsf@gmail.com> <83wpdt8yo2.fsf@gnu.org> <87inpd650y.fsf@gmail.com> <8660ldabje.fsf@stephe-leake.org> <8737gh5sqw.fsf@gmail.com> <87k29tv0r4.fsf@engster.org> <8737gguipm.fsf@engster.org> <87h94vdj3n.fsf@gmail.com> <87o9z2sog1.fsf@engster.org> <87d1fe3hof.fsf@engster.org> <87lgtwtfuc.fsf@gmail.com> <874m0k1age.fsf@engster.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1485595459 19319 195.159.176.226 (28 Jan 2017 09:24:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 28 Jan 2017 09:24:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Eli Zaretskii , Stephen Leake , emacs-devel@gnu.org To: David Engster Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 28 10:24:14 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXPEw-000412-W5 for ged-emacs-devel@m.gmane.org; Sat, 28 Jan 2017 10:24:11 +0100 Original-Received: from localhost ([::1]:50998 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXPEz-0006uw-9o for ged-emacs-devel@m.gmane.org; Sat, 28 Jan 2017 04:24:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44269) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXPEs-0006uZ-7y for emacs-devel@gnu.org; Sat, 28 Jan 2017 04:24:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXPEp-0005dH-35 for emacs-devel@gnu.org; Sat, 28 Jan 2017 04:24:06 -0500 Original-Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:35623) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXPEo-0005d0-TJ; Sat, 28 Jan 2017 04:24:03 -0500 Original-Received: by mail-wm0-x241.google.com with SMTP id d140so63940983wmd.2; Sat, 28 Jan 2017 01:24:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=WIKReZzjHJM/QLq+8lJ2DTarKBT8Va+XA91OOOn/OGk=; b=SgyKruQ9KL9jATOAkBVnDECYhmwzTkXgmUSgvIEqVAyObUlaKJ5MN76YFI5tfWzcBQ Wdzi1A2ap6FlJu98T7t0xu82qqBBcBRGRfVckARaS1gjQxY3c2vmKJc4KWLgHXQ78jrs efQWfNuXuH9T2PJLUFbbmoaVQNOIZ6RbbsXBquxB0IKoFqljQ0n1Y4ah1id3y1pwwD7I +K/F3b/oH7pZ1sOud2nmWonx4qD+8g4hCO2WEz1+3+AZIY27qyfeNIjmC4m94PNZhkZO Uzkk3FYHJbEnldJNuILY1kMP86QEt2U4noKq6CBMCAuA+40VDo32YFHkw/P51z4bXtd8 wyzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=WIKReZzjHJM/QLq+8lJ2DTarKBT8Va+XA91OOOn/OGk=; b=eJpMxVInf/EJWDeCq8okVgtNYyXffxZHmLVyEMqLmj/H6OtBU+0dF9sT9V+k+xZ6yZ GbbpnulIo6bKc4eEbXtrJ9VdB6cacL0PhiSDvLNxcPRDDOw6fDI7ArK1eSi262WItk30 b5c85GoJFqam54U66M5GxCAaBQ32WrYs3LddiYqSGE0QoyVQml8x6qmpB8DazhqEQOCT wi8vPcR6iX4X3P3le+X13RtFg59PLrQJwAEa8F8tH1eFUPk62DV27pAygGCppncb9pTI fK3xwjgNILByzMlqxlwcLShm3A2BFEAZ7wC8CSizoaJuAGGfZ5N+CN23xM4zpZswLSfV +t6w== X-Gm-Message-State: AIkVDXK5HH03Rh5wtLhSymQL7FS5gjInWIeMh7XE3COFbU7v09TF8GTeX1aIg1U5poSRiA== X-Received: by 10.223.134.151 with SMTP id 23mr13079494wrx.0.1485595441695; Sat, 28 Jan 2017 01:24:01 -0800 (PST) Original-Received: from edward ([41.193.194.172]) by smtp.gmail.com with ESMTPSA id b87sm7994007wmi.0.2017.01.28.01.23.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 28 Jan 2017 01:24:00 -0800 (PST) In-Reply-To: <874m0k1age.fsf@engster.org> (David Engster's message of "Fri, 27 Jan 2017 22:04:17 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::241 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211677 Archived-At: > There seems to be a misunderstanding here: The ChangeLog is generated > from the commit log and not written separately anymore. Alright. Out of interest: is there a command for generating all of the entries for a commit range? I'm only aware of C-x 4 a (add-change-log-entry-other-window) which seems to generate a change log entry for the current file and only for the latest commit. > I don't think it makes sense to fix up all the commits messages. The > commits you've merged go back to the beginning of CEDET, and I don't > think there's any sense it writing proper ChangeLogs for them now. They > are only tests, after all. However, it is very good that we have the > history on your branch, because it makes it much easier to check if all > authors have signed papers (last I asked, authors of non-trivial tests > were also required to have papers signed with the FSF). > > In my opinion, once we have decided which tests to keep and fixed them, > we should squash them and commit it as a new test suite. Agreed. >> Finally; the tests don't run with the CEDET in Emacs. > > That's totally expected. I'll take a look at them. > > -David I've just made some fixes to the tests this morning (I had messed up the merge of ia-utest.el and missed the whole of the cpproot directory for utests.) With that change the tests run with my current Emacs (which runs the modified CEDET that I created by merging Emacs-CEDET -> CEDET.) To anyone who has pulled my branch, scratch/merge-cedet-tests, I'd just ask that you git pull -f because I rewrote that branches history to correct my mistake.