Bug: Image export with link does not support query delimiter [8.2.10 (release_8.2.10 @ /usr/local/share/emacs/25.2/lisp/org/)]

Bug: Image export with link does not support query delimiter [8.2.10 (release_8.2.10 @ /usr/local/share/emacs/25.2/lisp/org/)]

[Damien Cassou]

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     http://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------

Given this org file

    [[http://foo.com][https://foo.com/badge.svg]]

    [[http://foo.com][https://foo.com/badge.svg?branch=master]]


I get this when exporting to HTML:

      <div class="figure">
        <p>
          <a href="http://foo.com">
            <img src="https://foo.com/badge.svg" alt="badge.svg" />
          </a>
        </p>
      </div>

      <p>
        <a href="http://foo.com">
          <a href="https://foo.com/badge.svg?branch=master">https://foo.com/badge.svg?branch=master</a>
        </a>
      </p>


I was expecting both outputs to be figures with an image. It seems that
the query "?branch=master" at the end of the URL prevents the output of
a picture.

Emacs  : GNU Emacs 25.2.4 (x86_64-unknown-linux-gnu, GTK+ Version 3.22.10)
 of 2017-03-18
Package: Org-mode version 8.2.10 (release_8.2.10 @ /usr/local/share/emacs/25.2/lisp/org/)

current state:
==============
(setq
 org-id-locations-file "/home/cassou/.emacs.d/var/org/id-locations.el"
 org-hide-leading-stars t
 org-clock-clocked-in-display nil
 org-tab-first-hook '(org-hide-block-toggle-maybe org-src-native-tab-command-maybe org-babel-hide-result-toggle-maybe
                      org-babel-header-arg-expand)
 org-latex-classes '(("beamer" "\\documentclass[presentation]{beamer}" ("\\section{%s}" . "\\section*{%s}")
                      ("\\subsection{%s}" . "\\subsection*{%s}") ("\\subsubsection{%s}" . "\\subsubsection*{%s}"))
                     ("article" "\\documentclass[11pt]{article}" ("\\section{%s}" . "\\section*{%s}")
                      ("\\subsection{%s}" . "\\subsection*{%s}") ("\\subsubsection{%s}" . "\\subsubsection*{%s}")
                      ("\\paragraph{%s}" . "\\paragraph*{%s}") ("\\subparagraph{%s}" . "\\subparagraph*{%s}"))
                     ("report" "\\documentclass[11pt]{report}" ("\\part{%s}" . "\\part*{%s}")
                      ("\\chapter{%s}" . "\\chapter*{%s}") ("\\section{%s}" . "\\section*{%s}")
                      ("\\subsection{%s}" . "\\subsection*{%s}") ("\\subsubsection{%s}" . "\\subsubsection*{%s}"))
                     ("book" "\\documentclass[11pt]{book}" ("\\part{%s}" . "\\part*{%s}")
                      ("\\chapter{%s}" . "\\chapter*{%s}") ("\\section{%s}" . "\\section*{%s}")
                      ("\\subsection{%s}" . "\\subsection*{%s}") ("\\subsubsection{%s}" . "\\subsubsection*{%s}"))
                     )
 org-clock-persist-file "/home/cassou/.emacs.d/var/org/clock-persist.el"
 org-speed-command-hook '(org-speed-command-default-hook org-babel-speed-command-hook)
 org-ellipsis "⤵"
 org-occur-hook '(org-first-headline-recenter)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-html-format-drawer-function '(lambda (name contents) contents)
 org-log-done 'time
 org-latex-format-inlinetask-function 'ignore
 org-confirm-shell-link-function 'yes-or-no-p
 org-ascii-format-inlinetask-function 'org-ascii-format-inlinetask-default
 org-startup-align-all-tables t
 org-twbs-format-headline-function 'ignore
 org-file-apps '(("\\.png\\'" . default) (t unify-opening-open file) (auto-mode . emacs) ("\\.mm\\'" . default)
                 ("\\.x?html?\\'" . default) ("\\.pdf\\'" . default))
 org-export-with-toc nil
 org-special-ctrl-a/e t
 org-twbs-format-inlinetask-function 'ignore
 org-agenda-custom-commands '((" " "Agenda"
                               ((agenda "" nil)
                                (tags "REFILE"
                                 ((org-agenda-overriding-header "Tasks to Refile") (org-tags-match-list-sublevels nil)))
                                )
                               nil)
                              )
 org-latex-format-headline-function 'org-latex-format-headline-default-function
 org-default-notes-file "~/Documents/configuration/org/refile.org"
 org-capture-templates '(("t" "Todo" entry (file org-default-notes-file) "* TODO %?%i")
                         ("s" "Schedule" entry (file org-default-calendar-file) "* %?\n%^T"))
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-latex-format-drawer-function '(lambda (name contents) contents)
 org-html-postamble nil
 org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer)
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-babel-pre-tangle-hook '(save-buffer)
 org-table-use-standard-references nil
 org-mode-hook '(er/add-org-mode-expansions
                 (lambda nil
                  (org-add-hook (quote change-major-mode-hook) (quote org-show-block-all) (quote append) (quote local)))
                 #[nil "\300\301\302\303\304$\207"
                   [org-add-hook change-major-mode-hook org-babel-show-result-all append local] 5]
                 org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-refile-targets '((("~/Documents/configuration/org/repeating.org" "~/Documents/configuration/org/someday.org"
                        "~/Documents/configuration/org/tasks.org")
                       :maxlevel . 2)
                      )
 org-fontify-done-headline t
 org-outline-path-complete-in-steps nil
 org-use-speed-commands t
 org-ascii-format-drawer-function '(lambda (name contents width) contents)
 org-ctrl-c-ctrl-c-hook '(org-babel-hash-at-point org-babel-execute-safely-maybe)
 org-directory "~/Documents/configuration/org"
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-hide-inline-tasks
                  org-cycle-show-empty-lines org-optimize-window-after-visibility-change)
 org-todo-keywords '((sequence "TODO(t)" "|" "DONE(d)" "CANCELLED(c)"))
 org-time-stamp-rounding-minutes '(10 10)
 org-modules '(org-protocol org-capture ox-beamer)
 org-catch-invisible-edits 'error
 org-export-allow-bind-keywords t
 org-babel-tangle-lang-exts '(("python" . "py") ("java" . "java") ("emacs-lisp" . "el"))
 org-confirm-elisp-link-function 'yes-or-no-p
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-twbs-format-drawer-function '(lambda (name contents) contents)
 org-html-format-headline-function 'ignore
 org-completion-use-ido t
 org-export-creator-string ""
 org-babel-load-languages '((nim . t) (sh . t) (emacs-lisp . t) (java . t) (python . t))
 org-html-format-inlinetask-function 'ignore
 org-agenda-files '("~/Documents/configuration/org/schplaf.org" "~/Documents/configuration/org/repeating.org"
                    "~/Documents/configuration/org/tasks.org" "~/Documents/configuration/org/refile.org")
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 )
-- 
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

Re: Bug: Image export with link does not support query delimiter [8.2.10 (release_8.2.10 @ /usr/local/share/emacs/25.2/lisp/org/)]

[Nicolas Goaziou]

Hello,

Damien Cassou <damien@cassou.me> writes:

> Remember to cover the basics, that is, what you expected to happen and
> what in fact did happen.  You don't know how to make a good report?  See
>
>      http://orgmode.org/manual/Feedback.html#Feedback
>
> Your bug report will be posted to the Org-mode mailing list.
> ------------------------------------------------------------------------
>
> Given this org file
>
>     [[http://foo.com][https://foo.com/badge.svg]]
>
>     [[http://foo.com][https://foo.com/badge.svg?branch=master]]
>
>
> I get this when exporting to HTML:
>
>       <div class="figure">
>         <p>
>           <a href="http://foo.com">
>             <img src="https://foo.com/badge.svg" alt="badge.svg" />
>           </a>
>         </p>
>       </div>
>
>       <p>
>         <a href="http://foo.com">
>           <a href="https://foo.com/badge.svg?branch=master">https://foo.com/badge.svg?branch=master</a>
>         </a>
>       </p>
>
>
> I was expecting both outputs to be figures with an image. It seems that
> the query "?branch=master" at the end of the URL prevents the output of
> a picture.

Couldn't you extend `org-html-inline-image-rules'?

Regards,

-- 
Nicolas Goaziou

Re: Bug: Image export with link does not support query delimiter [8.2.10 (release_8.2.10 @ /usr/local/share/emacs/25.2/lisp/org/)]

[Damien Cassou]

Hi Nicolas,

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

>> Given this org file 
>> 
>>     [[http://foo.com][https://foo.com/badge.svg]] 
>> 
>>     [[http://foo.com][https://foo.com/badge.svg?branch=master]] 
>> [...]  I was expecting both outputs to be figures with an 
>> image. It seems that the query "?branch=master" at the end of 
>> the URL prevents the output of a picture. 
> 
> Couldn't you extend `org-html-inline-image-rules'? 

thanks for the suggestion. I have tried several ways to specify a 
value for this variable inside the file but failed to make the 
export change in any way. I can't change the value of the file in 
my .emacs.d as I expect github's org engine to take care of 
exporting the html.

Thanks 

-- 
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

Re: Bug: Image export with link does not support query delimiter [8.2.10 (release_8.2.10 @ /usr/local/share/emacs/25.2/lisp/org/)]

[Damien Cassou]

Damien Cassou <damien@cassou.me> writes:
> thanks for the suggestion. I have tried several ways to specify 
> a  value for this variable inside the file but failed to make 
> the  export change in any way. I can't change the value of the 
> file in  my .emacs.d as I expect github's org engine to take 
> care of  exporting the html. 

I forgot to say I tried this:

    #+OPTIONS: html-inline-image-rules: (("https" 
    . "zzzzzzzzzzzzz")) * Foo 
      :PROPERTIES: :html-inline-image-rules: (("https" 
      . "zzzzzzzzzzzzzzzzzzzz")) :END: 
     
    [[http://bar.com][https://bar.com/badge.svg]] 
    [[http://foo.com][https://foo.com/badge.svg?branch=master]] 

Both links are still exported the exact same way so I guess the 
variable setting has no effect. What am I doing wrong?


-- 
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

Re: Bug: Image export with link does not support query delimiter [8.2.10 (release_8.2.10 @ /usr/local/share/emacs/25.2/lisp/org/)]

[Nicolas Goaziou]

Hello,

Damien Cassou <damien@cassou.me> writes:

> thanks for the suggestion. I have tried several ways to specify
> a value for this variable inside the file but failed to make the
> export change in any way.

I succeeded with

  #+bind: org-html-inline-image-rules (("http" . "\\.foo\\'"))

  * Test

  [[http://orgmode.org/image.foo]]

This assumes `org-export-allow-bind-keywords' is non-nil, which may not
be the case within Github's Org engine. Maybe it could be set to
a non-nil value there.

Regards,

-- 
Nicolas Goaziou                                                0x80A93738

Re: Bug: Image export with link does not support query delimiter [8.2.10 (release_8.2.10 @ /usr/local/share/emacs/25.2/lisp/org/)]

[Damien Cassou]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>> thanks for the suggestion. I have tried several ways to specify 
>> a value for this variable inside the file but failed to make 
>> the export change in any way. 
> 
> I succeeded with 
> 
>   #+bind: org-html-inline-image-rules (("http" . "\\.foo\\'")) 
> 
>   * Test 
> 
>   [[http://orgmode.org/image.foo]] 
> 
> This assumes `org-export-allow-bind-keywords' is non-nil, which 
> may not be the case within Github's Org engine. Maybe it could 
> be set to a non-nil value there. 

I can't make that work on GitHub. Any other suggestion? 

-- 
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill