all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: emacs-devel@gnu.org
Cc: Jeff Clough <kb1vqh@gmail.com>
Subject: Re: master cd0a795: Output number of characters added to file (Bug#354)
Date: Fri, 07 Apr 2017 15:42:27 +0200	[thread overview]
Message-ID: <8760igpc58.fsf@detlef> (raw)
In-Reply-To: <20170407022531.17D812084C@vcs0.savannah.gnu.org> (Noam Postavsky's message of "Thu, 6 Apr 2017 22:25:30 -0400 (EDT)")

npostavs@gmail.com (Noam Postavsky) writes:

> diff --git a/lisp/net/tramp-sh.el b/lisp/net/tramp-sh.el
> index 9977162..f78f541 100644
> --- a/lisp/net/tramp-sh.el
> +++ b/lisp/net/tramp-sh.el
> @@ -3411,7 +3411,8 @@ the result will be a local, non-Tramp, file name."
>          (when need-chown
>            (tramp-set-file-uid-gid filename uid gid))
>  	(when (or (eq visit t) (null visit) (stringp visit))
> -	  (tramp-message v 0 "Wrote %s" filename))
> +          (tramp-message v 0 "Wrote %d characters to `%s'"
> +                         (- end start) filename))

This breaks Tramp tests. In `write-region', START could be also nil or a
string.

Likely, the other changes suffer from the same problem.

Best regards, Michael.



  parent reply	other threads:[~2017-04-07 13:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170407022529.14820.30445@vcs0.savannah.gnu.org>
     [not found] ` <20170407022531.17D812084C@vcs0.savannah.gnu.org>
2017-04-07  3:30   ` master cd0a795: Output number of characters added to file (Bug#354) Mark Oteiza
2017-04-07  7:14     ` Eli Zaretskii
2017-04-07 22:50       ` Paul Eggert
2017-04-07 23:02         ` Kaushal Modi
2017-04-08  0:13           ` Noam Postavsky
2017-04-08  0:16       ` Mark Oteiza
2017-04-07 12:06     ` Noam Postavsky
2017-04-08  0:17       ` Mark Oteiza
2017-04-08  7:34         ` Eli Zaretskii
2017-04-08 14:08           ` Mark Oteiza
2017-04-09 20:03       ` Mark Oteiza
2017-04-07 13:42   ` Michael Albinus [this message]
2017-04-07 22:27     ` Noam Postavsky
2017-04-07 16:48   ` Glenn Morris
2017-04-07 21:41     ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8760igpc58.fsf@detlef \
    --to=michael.albinus@gmx.de \
    --cc=emacs-devel@gnu.org \
    --cc=kb1vqh@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.