From: Tino Calancha <tino.calancha@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: vianchielfaura@gmail.com, 28008@debbugs.gnu.org
Subject: bug#28008: 25.2; Resume kmacro definition errors C-u C-u <F3>
Date: Sat, 12 Aug 2017 12:03:45 +0900 [thread overview]
Message-ID: <8760dt32su.fsf@calancha-pc> (raw)
In-Reply-To: <alpine.DEB.2.20.1708112207420.17216@calancha-pc> (Tino Calancha's message of "Fri, 11 Aug 2017 22:17:57 +0900 (JST)")
Tino Calancha <tino.calancha@gmail.com> writes:
> On Fri, 11 Aug 2017, Eli Zaretskii wrote:
>
>>> ** Patch 1 always save the macro in `last-kbd-macro' after an error or 'C-g'.
>>> Then, A. B. and D.2 behaves similarly.
> Actually, the patch#1 is quite short: i included a docstring fix from
> the patch#2 by mistake.
The commit message of patch#1 got too verbose. It shouldn't mention
about 'last-aborted-kbd-macro' (that variable belongs to patch#2):
Following is a revisede commit message for patch#1:
--8<-----------------------------cut here---------------start------------->8---
Save aborted kbd macro definitions
While a defining a kbd macro, if we get an error or if the user inputs C-g,
then save the aborted kbd macro record (Bug#28008).
* lisp/kmacro.el (kmacro-start-macro): Signal an error if APPEND is non-nil
and last-kbd-macro is nil.
* src/keyboard.c (cmd_error): Increase buffer size for macroerror
to accommodate new error message.
If we are defining a kbd macro and we got an error, then save the
current progress in last-kbd-macro.
* src/macros.c (save_aborted_kbd_macro): New function.
(store_kbd_macro_char): Call save_aborted_kbd_macro when user inputs C-g.
--8<-----------------------------cut here---------------end--------------->8---
next prev parent reply other threads:[~2017-08-12 3:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 4:10 bug#28008: 25.2; Resume kmacro definition errors C-u C-u <F3> Allen Li
2017-08-08 5:26 ` Tino Calancha
2017-08-08 17:16 ` Allen Li
2017-08-11 12:41 ` Tino Calancha
2017-08-11 13:00 ` Eli Zaretskii
2017-08-11 13:17 ` Tino Calancha
2017-08-12 3:03 ` Tino Calancha [this message]
2017-08-13 21:13 ` Allen Li
2017-09-18 20:02 ` Allen Li
2017-09-19 7:42 ` Allen Li
2017-09-30 3:47 ` Allen Li
2017-09-30 4:20 ` Tino Calancha
2017-09-30 13:48 ` Eli Zaretskii
2020-08-24 14:07 ` Lars Ingebrigtsen
2018-09-09 0:23 ` Allen Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760dt32su.fsf@calancha-pc \
--to=tino.calancha@gmail.com \
--cc=28008@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=vianchielfaura@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.