From: Daniel Kraus <daniel@kraus.my>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: 18951@debbugs.gnu.org
Subject: bug#18951: eshell-pcomplete removes asterisk when attempting completion
Date: Thu, 02 Nov 2017 22:15:53 +0800 [thread overview]
Message-ID: <8760assr52.fsf@kraus.my> (raw)
In-Reply-To: <87po909arm.fsf@users.sourceforge.net>
[-- Attachment #1: Type: text/plain, Size: 739 bytes --]
Noam Postavsky <npostavs@users.sourceforge.net> writes:
> Hmm, does this do the right thing?
>
> --- i/lisp/pcomplete.el
> +++ w/lisp/pcomplete.el
> @@ -772,7 +772,7 @@ pcomplete-parse-arguments
> (setq c (cdr c)))
> (setq pcomplete-stub (substring common-stub 0 len)
> pcomplete-autolist t)
> - (when (and begin (not pcomplete-show-list))
> + (when (and begin (> len 0) (not pcomplete-show-list))
> (delete-region begin (point))
> (pcomplete-insert-entry "" pcomplete-stub))
> (throw 'pcomplete-completions completions))
I didn't test it too much if something else breaks but it
seems to work. pcomplete doesn't remove the * and company
mode also seems to work without problems now.
Thanks
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2017-11-02 14:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 5:50 bug#18951: 24.4.51; eshell-pcomplete removes asterisk when attempting completion Dmitry Gutov
2017-11-01 4:16 ` bug#18951: " Daniel Kraus
2017-11-01 12:46 ` Noam Postavsky
2017-11-02 7:00 ` Daniel Kraus
2017-11-02 11:32 ` Noam Postavsky
2017-11-02 14:15 ` Daniel Kraus [this message]
2017-11-03 21:25 ` Dmitry Gutov
2017-11-05 17:17 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760assr52.fsf@kraus.my \
--to=daniel@kraus.my \
--cc=18951@debbugs.gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.