From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: windows installer Date: Fri, 10 Nov 2017 17:01:39 +0000 Message-ID: <8760aijcek.fsf@russet.org.uk> References: <87po99qzbn.fsf@russet.org.uk> <1509955878.550800.1162811960.541B525D@webmail.messagingengine.com> <87h8u6bae3.fsf@russet.org.uk> <1510126271.1965593.1165373624.0601E5CF@webmail.messagingengine.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1510333483 18626 195.159.176.226 (10 Nov 2017 17:04:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 10 Nov 2017 17:04:43 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: jostein@kjonigsen.net, emacs-devel@gnu.org To: Jostein =?utf-8?Q?Kj=C3=B8nigsen?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 10 18:04:34 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eDCjJ-0004TQ-UQ for ged-emacs-devel@m.gmane.org; Fri, 10 Nov 2017 18:04:34 +0100 Original-Received: from localhost ([::1]:42669 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eDCjQ-0008QV-8N for ged-emacs-devel@m.gmane.org; Fri, 10 Nov 2017 12:04:40 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eDCge-0007JA-28 for emacs-devel@gnu.org; Fri, 10 Nov 2017 12:01:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eDCgZ-0003Ql-4W for emacs-devel@gnu.org; Fri, 10 Nov 2017 12:01:48 -0500 Original-Received: from cloud103.planethippo.com ([78.129.138.110]:37204) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eDCgY-0003OC-Np for emacs-devel@gnu.org; Fri, 10 Nov 2017 12:01:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=g5nySlyMUzfpphbhpJDoFMwzO7b857wHXmx00CgpAy8=; b=n6oXUUflaUDVDw83dnkn8LD9Af twIfQUDfwHEj5MS9vkvlsGljN2Vk6M/PG3X4DN26M+lGXJ/JsQeqMgqFHEBuC/c+40QY0VuiRirkh lWDjEyFKczmA6ukZUUOBjUWhF0PnKkBF2Hi1rjH5QUDYXBv56KWdRh7HBHXoPpV+UqkCLSzHHs7Yz STy1IX7IonpsF2lcuuhb6mLSC84/XD4UlrGH5PC7F0bfLDu2iEK+9dGmf+mxEmVitFM03r7FIIEB+ lT+gyH8cpEk2h4zpjwYKFSGD/g8hcOf/AFmcK70WE6yMcoObiB/9FdtCJaTdblBy2cZzr9+ksamlT plE2JGxg==; Original-Received: from janus-nat-128-240-225-124.ncl.ac.uk ([128.240.225.124]:33557 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1eDCgW-003Gjt-8p; Fri, 10 Nov 2017 17:01:40 +0000 In-Reply-To: <1510126271.1965593.1165373624.0601E5CF@webmail.messagingengine.com> ("Jostein =?utf-8?Q?Kj=C3=B8nigsen=22's?= message of "Wed, 08 Nov 2017 08:31:11 +0100") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-Source: X-Source-Args: X-Source-Dir: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 78.129.138.110 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:220030 Archived-At: Jostein Kj=C3=B8nigsen writes: > This is no doubt a major-improvement. Thank you! > If I were to provide some feedback or comments, I would like to point > out a few things. > > 1. Not commonly downloaded (yet) > > For the time being, the installer is reported as "not commonly > downloaded", and gives a big red warning in MS EDGE. I'm guessing > you'll get the same in Chrome, and also possibly Firefox: > > I've seen this before when developing and delivering other > Windows-software, and this should only appear in a transitional phase. > > This will make the initial roll-out a little more painful, but it >should basically resolve itself over time. > > I'm just mentioning this, so that if you get other comments on the > same subject, I don't think you need to be overly worried about it. Okay. For the snapshots, I will probably start adding a date to the file name which will exacerbate this, but as you say it should go away when Emacs-27 comes out. > 2. Installer is not signed > > These days trying to distribute a unsigned installer on Windows is > getting increasingly cumbersome. Especially for the end-users trying > to run it. Yeah, couldn't agree more. This has to be fixed. > The solution is signing the installer. Signing an installer (and any > EXE-file really) is fairly trivial and there are tools for this in the > Windows SDK. (And make sure to use the time-stamp options too!) > > To do this of course, you will have to be in possession of a X509 > code-signing certificate. If GNU already has one of these, it should > be easy to convert into whatever format Windows expects it to be in, > and put into use. A single GNU one would be the thing, I think. > If this is deemed important enough to resolve, I think the first > course of action will have to be finding an affordable option for > buying and renewing code-signing certificates. > > Managing the security of this certificate is also important concern, > but one we can dig deeper into at a later point. One solution here would be to sign the exe's when I upload them; this means that the signature would happen inside gnu.org. AFAICT, it's possible to do the signature with mono based tools -- so gnu.org would not need a windows box to achieve this. I guess they'd need to re-GPG sign it also, as signtool signature would break the GPG one. > Also setting up code-signing in a CI-environment (and especially for a > FOSS-project) can be a bit of a pain. Is the Windows-installer built > in a CI-environment? Should it be? If so, this may also something we > will need to solve too, but again, that's definitely something for > later. Signing on upload would solve this also. But, no, the windows-installer, like the rest of the windows binaries on a cheap media box in my living room. > 3. Installer defaults > > Once launched the installer seems to work as intended. I do however quest= ion some of the defaults provided. > > Install default directory has IMO at least 2 issues: > > * The default is to install to a folder on the desktop. This is highly un= conventional. Yeah, known issue "Currently, it installs to Desktop which is not right, but was easy.". It's quick and easy to see what is going on there. > I suggest we instead use the user's profile folder. From an initial > probe, this can be found in at least the following > environment-variables on my Windows 10 test-machine: USERPROFILE (or > by concatenating HOMEDRIVE and HOMEPATH ). I'll fix this. > > * The default install-directory includes the Emacs-version. > > This means that if I create any mappings to this installed > Emacs-version, add it to the path, and I later want to upgrade Emacs > to a newer version... Will that be installed in a different place? > Will I have to re-register Emacs all over the registry and in all > open-with dialogs? No idea. I'm presuming most people will not add it to the path, but launch it from the shortcut that the installation adds. > Not including the version-number will give us much less issues down > the line, especially for upgrades. I think it will make it hard for the installer to notice downgrades, though. > > * It should be noted that the Start-menu folder created for Emacs also > contains the version number. > > For the same reasons given above, I advice that we also remove the > version-number from this folder too. Again, it will make upgrades and > similar scenarios much more hygienic, with less "old stuff" we have > to clean up, in order to avoid stale links, or double > program-registrations for the same piece of software. Would you be able to test the program-registrations for me? You should be able to do this just by changing the directory name. For the start menu, what about adding both "Emacs" and "Emacs-27"? > Apart from that, I'm all positive about this initiative and the > improvements it provides. This is just so much better. Me too. I'm tired of seeing blank looks on the faces of people shown the zip. Phil