From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 29220@debbugs.gnu.org,
"Pierre Téchoueyres" <pierre.techoueyres@free.fr>,
"Noam Postavsky" <npostavs@users.sourceforge.net>
Subject: bug#29220: 26.0.90; eieio-persistent-read fail to restore saved object.
Date: Tue, 05 Dec 2017 09:47:26 -0800 [thread overview]
Message-ID: <87609lcbip.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <jwv1skavsn3.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Mon, 04 Dec 2017 21:08:40 -0500")
On 12/04/17 21:08 PM, Stefan Monnier wrote:
>> --- a/lisp/emacs-lisp/eieio-base.el
>> +++ b/lisp/emacs-lisp/eieio-base.el
>> @@ -354,15 +354,34 @@ eieio-persistent-validate/fix-slot-value
>> proposed-value))
>> (t
>> proposed-value))))
>> + ((stringp proposed-value)
>> + ;; Remove string properties.
>> + (substring-no-properties proposed-value))
>> +
>> + ;; For hash-tables and vectors, the top-level `read' will not
>> + ;; "look inside" member values, so we need to do that
>> + ;; explicitly.
>> + ((hash-table-p proposed-value)
>> + (maphash
>> + (lambda (key value)
>> + (when (class-p (car-safe value))
>> + (setf (gethash key proposed-value)
>> + (eieio-persistent-convert-list-to-object
>> + value))))
>> + proposed-value)
>> + proposed-value)
>> +
>> + ((vectorp proposed-value)
>> + (dotimes (i (length proposed-value))
>> + (when (class-p (car-safe (aref proposed-value i)))
>> + (aset proposed-value i
>> + (eieio-persistent-convert-list-to-object
>> + (aref proposed-value i)))))
>> + proposed-value)
>
>> - ((stringp proposed-value)
>> - ;; Else, check for strings, remove properties.
>> - (substring-no-properties proposed-value))
>> -
>> - (t
>> - ;; Else, just return whatever the constant was.
>> - proposed-value))
>> - )
>> + (t
>> + ;; Else, just return whatever the constant was.
>> + proposed-value)))
>
> Not sure why the `stringp` part was reindented, and an empty line was
> lost (which de-synchronized the diff), but other than that, it looks fine.
Dunno about the reindentation, either, I guess I can discard those
changes.
>> + ((hash-table-p thing)
>> + (maphash
>> + (lambda (key val)
>> + (setf (gethash key thing)
>> + (read
>> + (with-output-to-string
>> + (temp-eieio-override-prin1 val)))))
>> + thing)
>> + (prin1 thing))
>> + ((vectorp thing)
>> + (dotimes (i (length thing))
>> + (aset thing i
>> + (read
>> + (with-output-to-string
>> + (temp-eieio-override-prin1
>> + (aref thing i))))))
>> + (prin1 thing))
>
> This looks wrong, OTOH:
> - temp-eieio-override-prin1 does not exist in my copy of Emacs
> `master`.
That was a temporary name to prevent these changes from wrecking my Gnus
and EBDB. I guess I should be working in a separate Emacs.
> - you modify the object you received, so while the print part will
> presumably work OK, the object left after that is unusable.
I should have realized that...
> Maybe a better option is to print something of the form
>
> (vector <exp1> <exp2> ...)
>
> i.e. not something that looks like a vector. Or otherwise, print the
> "standard" syntax of a vector/hash-table, but do it by hand rather than
> rely on prin1 to do it for us.
Would it be too "heavy" to just copy the object and modify the copy? It
seems like writing a list-like form will result in just as much
consing...?
Eric
next prev parent reply other threads:[~2017-12-05 17:47 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 22:04 bug#29220: 26.0.90; eieio-persistent-read fail to restore saved object Pierre Téchoueyres
2017-11-08 22:48 ` Eric Abrahamsen
2017-11-10 17:31 ` Pierre Téchoueyres
2017-11-10 18:12 ` Eric Abrahamsen
2017-11-10 18:32 ` Pierre Téchoueyres
2017-11-12 19:10 ` Noam Postavsky
2017-11-14 22:30 ` Pierre Téchoueyres
2017-11-15 2:02 ` Noam Postavsky
2017-11-15 15:29 ` Stefan Monnier
2017-11-17 19:56 ` Pierre Téchoueyres
2017-11-18 3:40 ` Noam Postavsky
2017-11-18 4:39 ` Eric Abrahamsen
2017-11-18 13:24 ` Noam Postavsky
2017-11-18 18:14 ` Eric Abrahamsen
2017-11-19 3:17 ` Noam Postavsky
2017-11-19 5:57 ` Eric Abrahamsen
2017-11-23 23:20 ` Pierre Téchoueyres
2017-11-24 0:09 ` Noam Postavsky
2017-11-28 21:39 ` Pierre Téchoueyres
2017-11-28 21:52 ` Noam Postavsky
2017-11-28 22:18 ` Pierre Téchoueyres
2017-11-29 1:09 ` Noam Postavsky
2017-11-29 15:18 ` Stefan Monnier
2017-11-28 22:10 ` Eric Abrahamsen
2017-11-29 15:15 ` Stefan Monnier
2017-12-01 17:25 ` Eric Abrahamsen
2017-12-01 17:55 ` Stefan Monnier
2017-12-03 0:17 ` Eric Abrahamsen
2017-12-03 18:35 ` Pierre Téchoueyres
2017-12-05 1:27 ` Eric Abrahamsen
2017-12-05 2:08 ` Stefan Monnier
2017-12-05 17:47 ` Eric Abrahamsen [this message]
2017-12-05 19:02 ` Stefan Monnier
2017-12-05 20:56 ` Eric Abrahamsen
2017-12-05 22:14 ` Stefan Monnier
2017-12-05 22:58 ` Eric Abrahamsen
2017-12-08 10:41 ` Eli Zaretskii
2017-12-09 16:59 ` Eric Abrahamsen
2017-12-12 23:21 ` Noam Postavsky
2017-12-15 20:26 ` Pierre Téchoueyres
2017-12-15 22:26 ` Pierre Téchoueyres
2017-12-16 23:42 ` Eric Abrahamsen
2018-02-20 19:50 ` Pierre Téchoueyres
2018-02-24 21:23 ` Eric Abrahamsen
2018-02-24 23:21 ` Pierre Téchoueyres
2018-02-24 23:40 ` Eric Abrahamsen
2018-02-25 0:34 ` Pierre Téchoueyres
2018-02-25 18:59 ` Eric Abrahamsen
2019-05-27 23:36 ` Noam Postavsky
2019-05-28 21:17 ` Eric Abrahamsen
2019-05-30 22:50 ` Noam Postavsky
2017-12-18 19:52 ` Eric Abrahamsen
2017-12-18 21:38 ` Stefan Monnier
2017-12-20 18:29 ` Eric Abrahamsen
2017-12-20 20:54 ` Stefan Monnier
2017-12-21 2:21 ` Eric Abrahamsen
2017-12-24 2:18 ` Eric Ludlam
2017-12-28 18:44 ` Eric Abrahamsen
2017-12-05 22:20 ` Pierre Téchoueyres
2018-01-24 19:17 ` Pierre Téchoueyres
2018-01-25 3:09 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87609lcbip.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=29220@debbugs.gnu.org \
--cc=monnier@IRO.UMontreal.CA \
--cc=npostavs@users.sourceforge.net \
--cc=pierre.techoueyres@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.