From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#29599: 26.0; `dframe.el' binds keys unconditionally when loaded Date: Mon, 18 Dec 2017 22:51:06 -0500 Message-ID: <876093bck5.fsf@users.sourceforge.net> References: <878tdzbimi.fsf@users.sourceforge.net> <161e969d-1b2b-4bcc-9e24-a932fe6a2655@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1513655420 10839 195.159.176.226 (19 Dec 2017 03:50:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 19 Dec 2017 03:50:20 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 29599@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 19 04:50:16 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eR8v1-0002QK-1w for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Dec 2017 04:50:15 +0100 Original-Received: from localhost ([::1]:43487 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eR8wz-0006Pp-Ep for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Dec 2017 22:52:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56649) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eR8wp-0006Nr-0R for bug-gnu-emacs@gnu.org; Mon, 18 Dec 2017 22:52:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eR8wk-0004PV-TA for bug-gnu-emacs@gnu.org; Mon, 18 Dec 2017 22:52:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60556) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eR8wk-0004Od-N3 for bug-gnu-emacs@gnu.org; Mon, 18 Dec 2017 22:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eR8wk-0006Hg-7t for bug-gnu-emacs@gnu.org; Mon, 18 Dec 2017 22:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Dec 2017 03:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29599 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29599-submit@debbugs.gnu.org id=B29599.151365547724105 (code B ref 29599); Tue, 19 Dec 2017 03:52:02 +0000 Original-Received: (at 29599) by debbugs.gnu.org; 19 Dec 2017 03:51:17 +0000 Original-Received: from localhost ([127.0.0.1]:41004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eR8w1-0006Gd-Eo for submit@debbugs.gnu.org; Mon, 18 Dec 2017 22:51:17 -0500 Original-Received: from mail-it0-f54.google.com ([209.85.214.54]:38606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eR8vz-0006GM-GW; Mon, 18 Dec 2017 22:51:15 -0500 Original-Received: by mail-it0-f54.google.com with SMTP id r6so1182716itr.3; Mon, 18 Dec 2017 19:51:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=yAbrrBlSAzN8f9OTEtB0EG0vW/UScghyPU0rQ7T3/S8=; b=CqpkEBZquaexrJKUYbWy/M4E4FeMR8xAv1keiIFwN/SJJeuMMbEMN/2TbsVRG/ODYL oi1iA763OUEaR6D7UYHRJajMvk8n+v87UfFwhgmT/L+pGNUqvvjza7QdBGmC3ug/FHZe gm+08ydXKVEGjUNe0DSxto/u/UW0v30KV7yTssYnEaOFOGyd4lekhqXjXifRYpO+m+d1 iFUFEBF+kd4r9ExKXRf7T/EReYU46E5q292LTQCe48wgkkZprirFne3vhwyH54z3nczR Rh4sVsIT4O3SC+Isr/DBsgpzVIwhLamA2jBEgtphBSM159X4PV6DT9DVnkRDe520b4xk 07gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=yAbrrBlSAzN8f9OTEtB0EG0vW/UScghyPU0rQ7T3/S8=; b=TseD6Uoziiy63fWC3I/vQJsH2E5bN62cbL7hYigsmG13w5sU6jgptgXoX2NvS3Yoqa CMsMlkX7uFzYqA/LSOHOO7NEvlVAN0yJzFx6V7Sbg6bHlUfVSJeYGoShSsSvf2aga5gT TXeGxz0pZY8FSgfbRm6tlRFBFZB0QrEQzS1/45roi+xbbQtCHtp1XbQMsqqDiKx9g+MZ FIapmGHxgVfdeITXs+nttCbWMp5ri1uH3EKdqZeF8XuuPJpLqLyQHMSZCVQmrs9m0iSJ erF6jYwhdp99NKQkRBZSSwESEjoyI4FD/jY2XTTsRqDzOhLEo21kJO7q96DfPhZFZNmC U6Ew== X-Gm-Message-State: AKGB3mLELVv/DKO8UxwfXoRTaiO7Yk85/4PMoAYX8loTMwk4/LKbfUnD wekRV9PUapVapfQbBEBZHHUuWw== X-Google-Smtp-Source: ACJfBos5zzyQd0Y9WSGPWk76e1VH4O11AD6v/Dgd7mIK7ROsN+J8bcKYZQGDw8rt6Uo4qlJH2icJsQ== X-Received: by 10.36.150.67 with SMTP id z64mr1696170itd.72.1513655469450; Mon, 18 Dec 2017 19:51:09 -0800 (PST) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id i133sm3104204itf.1.2017.12.18.19.51.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Dec 2017 19:51:07 -0800 (PST) In-Reply-To: <161e969d-1b2b-4bcc-9e24-a932fe6a2655@default> (Drew Adams's message of "Mon, 18 Dec 2017 18:15:10 -0800 (PST)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141241 Archived-At: tags 29599 + patch quit Drew Adams writes: >> Yeah (it's probably the loading-on-completion thing again). > > I don't think I know (or didn't know or at least don't > recall) anything about such a thing. Is it something new? Yes, see Bug#28607. >> Actually, it sort of looks like >> dframe is trying to install such a hook; the functions it puts don't do >> anything except call `dframe-make-frame-{visible,iconify,delete}- >> function'. > > But (without looking at them), those sound like specific > replacements for the standard iconify etc. If so, it's > great to provide such functions, but they shouldn't be > bound to special events by default (i.e., upon loading). As far as I can tell, there is no code in Emacs which sets those functions to anything. So presumably the idea is to allow the user to run some code when a "dframe" is made visible/iconified/deleted. >> Here's a patch which moves the keybinding to dframe-frame-mode >> activation instead. > > I can't speak to the value of the patch (I know nothing > about this), but thanks for working on this. Okay, it should take care of this bug, and it should be perfectly safe, since the functions do nothing before dframe-frame-mode is activated anyway. I'll push to emacs-26 in a few days if there are no objections.