From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Drew Adams <drew.adams@oracle.com>
Cc: 29599@debbugs.gnu.org
Subject: bug#29599: 26.0; `dframe.el' binds keys unconditionally when loaded
Date: Mon, 18 Dec 2017 22:51:06 -0500 [thread overview]
Message-ID: <876093bck5.fsf@users.sourceforge.net> (raw)
In-Reply-To: <161e969d-1b2b-4bcc-9e24-a932fe6a2655@default> (Drew Adams's message of "Mon, 18 Dec 2017 18:15:10 -0800 (PST)")
tags 29599 + patch
quit
Drew Adams <drew.adams@oracle.com> writes:
>> Yeah (it's probably the loading-on-completion thing again).
>
> I don't think I know (or didn't know or at least don't
> recall) anything about such a thing. Is it something new?
Yes, see Bug#28607.
>> Actually, it sort of looks like
>> dframe is trying to install such a hook; the functions it puts don't do
>> anything except call `dframe-make-frame-{visible,iconify,delete}-
>> function'.
>
> But (without looking at them), those sound like specific
> replacements for the standard iconify etc. If so, it's
> great to provide such functions, but they shouldn't be
> bound to special events by default (i.e., upon loading).
As far as I can tell, there is no code in Emacs which sets those
functions to anything. So presumably the idea is to allow the user to
run some code when a "dframe" is made visible/iconified/deleted.
>> Here's a patch which moves the keybinding to dframe-frame-mode
>> activation instead.
>
> I can't speak to the value of the patch (I know nothing
> about this), but thanks for working on this.
Okay, it should take care of this bug, and it should be perfectly safe,
since the functions do nothing before dframe-frame-mode is activated
anyway. I'll push to emacs-26 in a few days if there are no objections.
next prev parent reply other threads:[~2017-12-19 3:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 6:10 bug#29599: 26.0; `dframe.el' binds keys unconditionally when loaded Drew Adams
2017-12-19 1:40 ` Noam Postavsky
2017-12-19 2:15 ` Drew Adams
2017-12-19 3:51 ` Noam Postavsky [this message]
2017-12-19 5:21 ` Drew Adams
2017-12-19 13:15 ` Noam Postavsky
2017-12-19 15:22 ` Drew Adams
2018-01-03 1:59 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=876093bck5.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=29599@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.