From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#30131: 26.0.50; compile.el no longer calls compilation-parse-errors-filename-function Date: Mon, 15 Jan 2018 19:43:15 -0500 Message-ID: <876082pra4.fsf@users.sourceforge.net> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1516063342 11670 195.159.176.226 (16 Jan 2018 00:42:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 16 Jan 2018 00:42:22 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 30131@debbugs.gnu.org To: Gary Oberbrunner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 16 01:42:18 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebFKO-0002Cr-K4 for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Jan 2018 01:42:12 +0100 Original-Received: from localhost ([::1]:48615 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebFMM-0003hL-O9 for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Jan 2018 19:44:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebFMG-0003gw-Al for bug-gnu-emacs@gnu.org; Mon, 15 Jan 2018 19:44:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebFMA-0003mi-6j for bug-gnu-emacs@gnu.org; Mon, 15 Jan 2018 19:44:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50001) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebFMA-0003me-1h for bug-gnu-emacs@gnu.org; Mon, 15 Jan 2018 19:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ebFM9-0000n9-O4 for bug-gnu-emacs@gnu.org; Mon, 15 Jan 2018 19:44:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Jan 2018 00:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30131 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30131-submit@debbugs.gnu.org id=B30131.15160634052994 (code B ref 30131); Tue, 16 Jan 2018 00:44:01 +0000 Original-Received: (at 30131) by debbugs.gnu.org; 16 Jan 2018 00:43:25 +0000 Original-Received: from localhost ([127.0.0.1]:57898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebFLZ-0000mE-B7 for submit@debbugs.gnu.org; Mon, 15 Jan 2018 19:43:25 -0500 Original-Received: from mail-io0-f170.google.com ([209.85.223.170]:34808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebFLX-0000m1-V5 for 30131@debbugs.gnu.org; Mon, 15 Jan 2018 19:43:24 -0500 Original-Received: by mail-io0-f170.google.com with SMTP id c17so14961577iod.1 for <30131@debbugs.gnu.org>; Mon, 15 Jan 2018 16:43:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=DmNkfZ+aJJdh7rzb+HIORNdKFvlAwayezL2i6owGD74=; b=jjA/Rtf/DCydq0vNXfpZMmZvFwVhLSbxj40nCxgSsfx7tFVY6ZsK6sFiacSKwvEsUK 8QcNNQf82UZFjQisnQuss//gge9hsd2NKkqzvYIWsRHfsVOZeraC2eQ92G3C5H/OQW5g OA0vobOhvBy1EzUc34T2MkMxo2fAm0U/Qx0h8cMh/Ke6P8v4pAgBYLAryTspfTo9KVYl u0ly0KhNub/gEgEVS3q8fbzv7mr+MiLPvpkkzHM9ynCKzG01GeBgSeZ8iwJPG75eJV0N 927Q78E3EdEjzS8vTDXc1XnqHLDMCRui0H5k/AIRKBn/84bEaU5G41yK6Om9SFkmCZb1 4ivg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=DmNkfZ+aJJdh7rzb+HIORNdKFvlAwayezL2i6owGD74=; b=OhO0un6HeiNuVw9XCWcKMrirDT84evjHYGPDps+K9LK9OJGNkYoZWVBSCrMMdKc/v0 e4oPj956VoIHUh5vMhcGltd38r+14orytSJlRN6alZmNDKqIaXoSiDJBhwaEG/NfEChX XvLQPCjWQN9N4Uo7MQ8kmIJph09AABME3FNX+PYrleyQ7UyzniaB0YYvMN9ctX1Z5GBA Ek8dwjRD1+KBjvxXmnism2Ct80yO1hwH1CTBvNMJ4zJiQ2aMKjrPdPFsThOHDxdprS10 kpusxDR24W2cLrRMJvUi6POxj2QVUuGFnTnAhmECGeVMdt399x7DB9yFSXhbqlZy4wUC ODpA== X-Gm-Message-State: AKwxytdnrz0om5VVt1lKVeWmZoSGHU3zFTldL2hTqcRm9P2lnA/PFWMr wgb5ln5bAsaWoJ6iP7ZH21htGw== X-Google-Smtp-Source: ACJfBovkw87vGaf1VF/kG2FZAurySJQxtQNIcIeSh3s9z6RdpFesz3MPdroVJtMh8yK1SX/NZzcR7A== X-Received: by 10.107.114.16 with SMTP id n16mr36545187ioc.2.1516063398149; Mon, 15 Jan 2018 16:43:18 -0800 (PST) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id r2sm422189ioi.86.2018.01.15.16.43.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Jan 2018 16:43:16 -0800 (PST) In-Reply-To: (Gary Oberbrunner's message of "Mon, 15 Jan 2018 12:28:15 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142191 Archived-At: Gary Oberbrunner writes: > In git rev e335e1949, back in 2001, > compilation-parse-errors-filename-function was introduced to > compile.el, to postprocess filenames. Somewhere in the last few > months, emacs has stopped calling that function from > compilation-find-file, so it no longer works. (It's still called from > a function that now only is used for display, so it doesn't actually > find the processed filename.) As far as I can tell, it was never called from compilation-find-file. Not in e335e1949 that you referenced above, not in 25.3, 25.4, nor 24.3. In all recent Emacs versions, including latest emacs-26 and master, it is called from compilation-get-file-structure. (defun compilation-get-file-structure (file &optional fmt) [...] ;; If compilation-parse-errors-filename-function is ;; defined, use it to process the filename. (when compilation-parse-errors-filename-function (setq filename (funcall compilation-parse-errors-filename-function filename)))