all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Gary Oberbrunner <garyo@oberbrunner.com>
Cc: 30131@debbugs.gnu.org
Subject: bug#30131: 26.0.50; compile.el no longer calls compilation-parse-errors-filename-function
Date: Mon, 15 Jan 2018 19:43:15 -0500	[thread overview]
Message-ID: <876082pra4.fsf@users.sourceforge.net> (raw)
In-Reply-To: <CAFChFyjsQePQTawCL0AtK6Vh-v3HsVyrGOniGGbYn-UdUfj4aA@mail.gmail.com> (Gary Oberbrunner's message of "Mon, 15 Jan 2018 12:28:15 -0500")

Gary Oberbrunner <garyo@oberbrunner.com> writes:

> In git rev e335e1949, back in 2001,
> compilation-parse-errors-filename-function was introduced to
> compile.el, to postprocess filenames. Somewhere in the last few
> months, emacs has stopped calling that function from
> compilation-find-file, so it no longer works. (It's still called from
> a function that now only is used for display, so it doesn't actually
> find the processed filename.)

As far as I can tell, it was never called from compilation-find-file.
Not in e335e1949 that you referenced above, not in 25.3, 25.4, nor 24.3.

In all recent Emacs versions, including latest emacs-26 and master, it
is called from compilation-get-file-structure.

(defun compilation-get-file-structure (file &optional fmt)
  [...]
    ;; If compilation-parse-errors-filename-function is
	;; defined, use it to process the filename.
	(when compilation-parse-errors-filename-function
	  (setq filename
		(funcall compilation-parse-errors-filename-function
			 filename)))





  reply	other threads:[~2018-01-16  0:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-15 17:28 bug#30131: 26.0.50; compile.el no longer calls compilation-parse-errors-filename-function Gary Oberbrunner
2018-01-16  0:43 ` Noam Postavsky [this message]
2018-01-16  1:09   ` Gary Oberbrunner
2018-01-16  1:16     ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=876082pra4.fsf@users.sourceforge.net \
    --to=npostavs@users.sourceforge.net \
    --cc=30131@debbugs.gnu.org \
    --cc=garyo@oberbrunner.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.