all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Karl Fogel <kfogel@red-bean.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Unnecessarily moving stiff between files considered harmful
Date: Fri, 23 Mar 2018 13:03:08 -0500	[thread overview]
Message-ID: <87605macv7.fsf@red-bean.com> (raw)
In-Reply-To: <837eq4k2dk.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 22 Mar 2018 09:15:03 +0200")

Eli Zaretskii <eliz@gnu.org> writes:
>Btw, if I'm allowed a gripe: we have too much of this in our history
>already.  Just recently I wanted to know when the assertion in
>set_blv_found was born, and was unable to determine this using Git,
>because that function was first a macro, then an inline function, and
>migrated between 2 or 3 files several times.  I eventually had to use
>ChangeLog files from old Emacs releases(!) to find out the history of
>this single line.  I'm sure Git gurus will come up with some
>convoluted way to do that with Git, and Magit gurus will tell that
>Magit already knows how to do this.  But the fact that the usual tools
>of trade fail here is for me a clear indication that we should keep
>this disadvantage in mind when making such changes: there's a non-zero
>price here.

I looked at places in CONTRIBUTE where it might work to add a sentence or two about this, but didn't see any good places to fit it in, hmm.

I agree, there is a price.  (In the case of particular change we were discussing, I thought the price was worth paying, but there are always going to be edge-case disagreements about the relative value of moving code vs the negative effects of the churn.)



  reply	other threads:[~2018-03-23 18:03 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180311105533.30002.78782@vcs0.savannah.gnu.org>
     [not found] ` <20180311105534.3DAFD23CF3@vcs0.savannah.gnu.org>
2018-03-11 16:05   ` [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343) Stefan Monnier
2018-03-11 17:23     ` Charles A. Roelli
2018-03-12  9:56       ` Leo Liu
2018-03-11 18:13     ` Eli Zaretskii
2018-03-15 20:20       ` Richard Copley
2018-03-16 15:23         ` Karl Fogel
2018-03-20 21:33           ` Karl Fogel
2018-03-20 21:46             ` Richard Copley
2018-03-21  7:22             ` Eli Zaretskii
2018-03-22  5:30               ` Karl Fogel
2018-03-22  7:12                 ` Eli Zaretskii
2018-03-22  7:15                 ` Unnecessarily moving stiff between files considered harmful (Was: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive) (Bug#30343) Eli Zaretskii
2018-03-23 18:03                   ` Karl Fogel [this message]
2018-03-22 13:39                 ` [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343) Stefan Monnier
2018-03-23 18:05                   ` Karl Fogel
2018-03-25 10:03               ` Charles A. Roelli
2018-03-25 15:41                 ` Eli Zaretskii
2018-03-25 20:29                   ` Charles A. Roelli
2018-03-26 15:59                     ` Eli Zaretskii
2018-03-28 20:19                     ` Juri Linkov
2018-03-29  4:53                       ` Karl Fogel
2018-03-29 11:38                         ` Eli Zaretskii
2018-03-29 12:17                         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87605macv7.fsf@red-bean.com \
    --to=kfogel@red-bean.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.