From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#31073: 27.0.50; query-replace undo might change the word case Date: Sun, 08 Apr 2018 11:46:15 +0900 Message-ID: <876052e7pk.fsf@gmail.com> References: <87efjtdj14.fsf@gmail.com> <87370621fb.fsf@mail.linkov.net> <87a7ueebza.fsf@gmail.com> <83tvsmzatd.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1523155507 9875 195.159.176.226 (8 Apr 2018 02:45:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 8 Apr 2018 02:45:07 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 31073@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 08 04:45:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f50KE-0002RL-8e for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Apr 2018 04:45:03 +0200 Original-Received: from localhost ([::1]:43909 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f50MJ-0002W0-EM for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Apr 2018 22:47:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47708) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f50MD-0002Ve-9j for bug-gnu-emacs@gnu.org; Sat, 07 Apr 2018 22:47:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f50MA-00081R-73 for bug-gnu-emacs@gnu.org; Sat, 07 Apr 2018 22:47:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33800) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f50MA-000817-2r for bug-gnu-emacs@gnu.org; Sat, 07 Apr 2018 22:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f50M9-0001Vg-Mn for bug-gnu-emacs@gnu.org; Sat, 07 Apr 2018 22:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Apr 2018 02:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31073 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31073-submit@debbugs.gnu.org id=B31073.15231555865760 (code B ref 31073); Sun, 08 Apr 2018 02:47:01 +0000 Original-Received: (at 31073) by debbugs.gnu.org; 8 Apr 2018 02:46:26 +0000 Original-Received: from localhost ([127.0.0.1]:41697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f50La-0001Uq-CE for submit@debbugs.gnu.org; Sat, 07 Apr 2018 22:46:26 -0400 Original-Received: from mail-pl0-f42.google.com ([209.85.160.42]:43953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f50LZ-0001Ua-9q for 31073@debbugs.gnu.org; Sat, 07 Apr 2018 22:46:25 -0400 Original-Received: by mail-pl0-f42.google.com with SMTP id a39-v6so3002975pla.10 for <31073@debbugs.gnu.org>; Sat, 07 Apr 2018 19:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=8SVzjnFh2RpRssFEcQB8Moq5/jbEaJu/EUakbK9djEI=; b=iLqVhpNbJzqu7JW37dldmKpVqjXBtomEjvsCc6m1b9n87IQ5IH8Jmp9fSiHi3V4mQB yMsp8Iw+wKXEEquve1bQkVaV0km5NFO+hErwPYSnviyTIdpOhZHXPZalAjrAuWzgv4fA PH44XPiUfyFplSTva7OPEDHwNNaWV42Tqp2N8r6u/LVkUq7i6uk2o8WIViDE+pkom88v IRH6PCXwt2obF4dLmS+UAxq3Pm9Mj+35QlAk2ECGKKLJwsU9r7z0V7XQVFaI50mIjXeB kVUWMA++s0r9eTijfU5WgmllLkbTLnnTH/g3Qs/x+e9agDjeHKF175FHupWaLCQJkDTU 3L5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=8SVzjnFh2RpRssFEcQB8Moq5/jbEaJu/EUakbK9djEI=; b=qPJsriRaksGg/OP8Ya1OeTrNKkUnHe9FfaSzS37fROdDGMqFb+F6Lb8PtkHf0iiMVO wVtxewkWF5UzJej4Au3SiVbCMfYZimlmQuh8lxnOsLav/XP2ossaRpu/Ihtmwiyzy4qV BN+632OXljZHj/4iroSG9vumUEo3sKTL5xwdyPYXoKx6a9HZ5RZFfxxr2fmKKB3lsC2h aYAuY/6TyN0p2UnR7mpZA4ncpatC8LTN+JRNH5bXyNgtq4+KuDja9qoaMLE7ikK010eO b2RtsAKPvBX0cJJ9qSgEKlBxRnW8MOi4tgeHsVGlvGs/xrNqi0FG5ALa2Tkz6+PWGq+/ te8Q== X-Gm-Message-State: AElRT7E6n3aqhXNDadXmeD0J9EMJbrMqkAEqgtyfVuiLcD3DUX5vGIyY 1VcZ+rtM+UH2FhSGEfTHWHxRSFa6 X-Google-Smtp-Source: AIpwx4/IdSMjiNNI59J6rJ+3JFh7lOXKMYPTTyoOD6B8d9w+g3RjEBdpW3LKqHjm6BeSIMY5LLCCmg== X-Received: by 2002:a17:902:5681:: with SMTP id j1-v6mr33565682pli.383.1523155579330; Sat, 07 Apr 2018 19:46:19 -0700 (PDT) Original-Received: from calancha-pc (15.224.128.101.dy.bbexcite.jp. [101.128.224.15]) by smtp.gmail.com with ESMTPSA id w26sm29694438pfi.17.2018.04.07.19.46.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 07 Apr 2018 19:46:18 -0700 (PDT) In-Reply-To: <83tvsmzatd.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 08 Apr 2018 05:33:34 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144976 Archived-At: Eli Zaretskii writes: >> this feature was introduced for Emacs-26 release. Should the fix go >> into that branch (Emacs-26)? > > It's too late for Emacs 26.1. For the other 26.x, I'd need to see the > patch first. I see. The patch is pretty obvious: just 1 line: --8<-----------------------------cut here---------------start------------->8--- commit a70414e82048f425cdb00e3cd30c15fcb9fbab86 Author: Tino Calancha Date: Fri Apr 6 14:03:55 2018 +0900 Preserve case in query-replace undo If the user query and replaces 'foo' with 'BAR', then undo must comeback to 'foo', not to 'FOO' (Bug#31073). * lisp/replace.el (perform-replace): Bind nocasify to non-nil value during undo/undo-all actions. diff --git a/lisp/replace.el b/lisp/replace.el index c28c9b36f0..2b0555d580 100644 --- a/lisp/replace.el +++ b/lisp/replace.el @@ -2619,6 +2619,7 @@ perform-replace (let ((stack-idx 0) (stack-len (length stack)) (num-replacements 0) + (nocasify t) ; Bug#31073. search-string next-replacement) (while (and (< stack-idx stack-len) --8<-----------------------------cut here---------------end--------------->8--- In GNU Emacs 27.0.50 (build 25, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) Repository revision: 8df23a82042fa7dbaaa4377bc376d705595b073f