bug#24648: 25.1; smie indentation in strings

bug#24648: 25.1; smie indentation in strings

[Leo Liu]

1. Open a new buffer in octave-mode (or ruby mode)
2. Insert a string:

     "line 1
     line 2
     line 3"

3. Move point to the beginning of `line 2' and pressing TAB

line 2 will be indented freely. This is a big surprise. Regression?

Leo

bug#24648: 25.1; smie indentation in strings

[Stefan Monnier]

> 1. Open a new buffer in octave-mode (or ruby mode)
> 2. Insert a string:
>
>      "line 1
>      line 2
>      line 3"
>
> 3. Move point to the beginning of `line 2' and pressing TAB
>
> line 2 will be indented freely. This is a big surprise. Regression?

What would you like instead?  You're indenting within a string, so
octave-mode has no idea what rule to follow since the string may
represent anything.  By design, it should behave like in text-mode, more
or less.


        Stefan

bug#24648: 25.1; smie indentation in strings

[Dmitry Gutov]

On 09.10.2016 19:45, Leo Liu wrote:
>
> 1. Open a new buffer in octave-mode (or ruby mode)
> 2. Insert a string:
>
>      "line 1
>      line 2
>      line 3"
>
> 3. Move point to the beginning of `line 2' and pressing TAB
>
> line 2 will be indented freely. This is a big surprise. Regression?

This is actually intentional, and was added in commit f54e5ccf.

bug#24648: 25.1; smie indentation in strings

[Leo Liu]

On 2016-10-12 13:00 +0300, Dmitry Gutov wrote:
> This is actually intentional, and was added in commit f54e5ccf.

Look at that commit it is not clear what the intention is.

On 2016-10-09 17:01 -0400, Stefan Monnier wrote:
> What would you like instead?  You're indenting within a string, so
> octave-mode has no idea what rule to follow since the string may
> represent anything.  By design, it should behave like in text-mode, more
> or less.
>
>
>         Stefan

The behaviour in emacs 24 and before looks sane. I have a hard time
getting used to this change. Previously noindent means no indention now
it seems to mean any indention. And there are exceptions for example
lisp modes don't adopt this behaviour. Any ideas why?

Leo

bug#24648: 25.1; smie indentation in strings

[Dmitry Gutov]

On 12.10.2016 19:57, Leo Liu wrote:
> I have a hard time
> getting used to this change. Previously noindent means no indention now
> it seems to mean any indention.

Only when you explicitly press TAB inside a string. That doesn't change 
region indentation, for instance.

To be clear, I probably don't care one way of the other. But just 
yesterday, a user requested this behavior in js2-mode: 
https://github.com/mooz/js2-mode/issues/227#issuecomment-253138470

> And there are exceptions for example
> lisp modes don't adopt this behaviour. Any ideas why?

Because most indent-line-function's don't return `noindent' when they 
should (in comments and strings).

We should probably patch that.

bug#24648: 25.1; smie indentation in strings

[Leo Liu]

On 2016-10-12 20:08 +0300, Dmitry Gutov wrote:
> Because most indent-line-function's don't return `noindent' when they
> should (in comments and strings).
>
> We should probably patch that.

SMIE handles comment and strings automatically by returning `noindent';
but pressing TAB still indents it anyway.

Leo

bug#24648: 25.1; smie indentation in strings

[Dmitry Gutov]

On 12.10.2016 20:39, Leo Liu wrote:
> On 2016-10-12 20:08 +0300, Dmitry Gutov wrote:
>> Because most indent-line-function's don't return `noindent' when they
>> should (in comments and strings).
>>
>> We should probably patch that.
>
> SMIE handles comment and strings automatically by returning `noindent';
> but pressing TAB still indents it anyway.

Yes. That's the effect of the commit I've referenced earlier.

bug#24648: 25.1; smie indentation in strings

[Noam Postavsky]

tags 24648 wontfix
close 24648
quit

Dmitry Gutov <dgutov@yandex.ru> writes:

> On 12.10.2016 20:39, Leo Liu wrote:
>> On 2016-10-12 20:08 +0300, Dmitry Gutov wrote:
>>> Because most indent-line-function's don't return `noindent' when they
>>> should (in comments and strings).
>>>
>>> We should probably patch that.
>>
>> SMIE handles comment and strings automatically by returning `noindent';
>> but pressing TAB still indents it anyway.
>
> Yes. That's the effect of the commit I've referenced earlier.

Sounds like wontfix to me.