From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#31764: 26.1; Point in VC change log is not centered as documented Date: Mon, 11 Jun 2018 20:10:17 -0400 Message-ID: <87602ozwye.fsf@gmail.com> References: <87vaatf5fn.fsf@gmail.com> <83k1r9t6ew.fsf@gnu.org> <83h8mdt4uq.fsf@gnu.org> <87sh5w245l.fsf@gmail.com> <83efhgtq25.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1528762146 4329 195.159.176.226 (12 Jun 2018 00:09:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 12 Jun 2018 00:09:06 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: carlosjosepita@gmail.com, 31764@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 12 02:09:02 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSWru-00010g-4c for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Jun 2018 02:09:02 +0200 Original-Received: from localhost ([::1]:51920 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSWu1-0003rL-2m for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Jun 2018 20:11:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSWtv-0003pI-CA for bug-gnu-emacs@gnu.org; Mon, 11 Jun 2018 20:11:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSWtq-0005Ra-9I for bug-gnu-emacs@gnu.org; Mon, 11 Jun 2018 20:11:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35914) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fSWtq-0005Qp-4l for bug-gnu-emacs@gnu.org; Mon, 11 Jun 2018 20:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fSWtp-0002i8-MP for bug-gnu-emacs@gnu.org; Mon, 11 Jun 2018 20:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jun 2018 00:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31764 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31764-submit@debbugs.gnu.org id=B31764.152876223110381 (code B ref 31764); Tue, 12 Jun 2018 00:11:01 +0000 Original-Received: (at 31764) by debbugs.gnu.org; 12 Jun 2018 00:10:31 +0000 Original-Received: from localhost ([127.0.0.1]:43811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSWtL-0002hI-AD for submit@debbugs.gnu.org; Mon, 11 Jun 2018 20:10:31 -0400 Original-Received: from mail-it0-f66.google.com ([209.85.214.66]:55418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSWtH-0002gy-Bz; Mon, 11 Jun 2018 20:10:27 -0400 Original-Received: by mail-it0-f66.google.com with SMTP id 16-v6so7862710itl.5; Mon, 11 Jun 2018 17:10:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=kIHxmq1Q/tLoxBJ98dAVh29USGD5JdfEcp7qQzo3X8Y=; b=vhRth6RtS284HejZherbbt4Qi7bD7P+WG8xSpI9fSz41szOvV91u8mc4Zd3Q+UNzXD HngFGN5LIbQVpm0UNPI32vg3XjEBh5pvTcIQrzIDNXqq+Aa2N76ettvg/k0REX79obr0 I3BtuGDMRDnxuidKKw0UQ4lhga/I5GtRz89Af090zcCuI8M0X9tJ24jQFE+JZ3KkN+T1 XLb4VVyE0TEj3Df0lgEoT16nvCcKxjkieN+t4UnlHyDq+xMfUqKibmyHfpdyjsz8BJX2 PspzxMs4SNIOyPUDMLEZHFH7fOR5GN4mc5CONB/0tGJn/xFDjItbRh+sZcSIKwHc8MiO /5eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=kIHxmq1Q/tLoxBJ98dAVh29USGD5JdfEcp7qQzo3X8Y=; b=NDG31dfNM4uv68uXaG1eI4v82RFRc0CpyG14cR1Pg1FYFOQd1MAetJ3EVm7LaA/hSa uzTFmRNSaIoHAgs4sEpsiMMb9uMaqhHs9SVV4bD57Gn9z+DTIgmnDb5zlxLwFwCnHAo2 P3SE1pTMSZDtpIckaw4LHK78Z5glHxT/FrAFe9WlYAdcjC/BDPuD610UipOykv8jcDqa Js5DAPVQF1+q9sBC9YFpaWLoA+5IIq9OuYyzEFfT65mHCfpvsGSSAGkE/x/A4jaSkMyM XyhUiSL8WmHj2KEYdCLZhNj/WLAhzx55whxZLnqoBjfHjkSp7ATHoPkA2t0Nuru1jnhC OWLA== X-Gm-Message-State: APt69E2pBlPIzrL2N7rsK2HQ/wJIV/Eq7pcHMzAbRX/J7yfkDmL9evHD mFNpKejhEn4gFblwHA3XmsxqLQ== X-Google-Smtp-Source: ADUXVKLGfqZVbCmeNZ9MCa56Sf3tWYB/9cj7kmTO/gTCkYYIeZ4ONzv5TKv0aqmXMLAVyZSgzCawuw== X-Received: by 2002:a24:e645:: with SMTP id e66-v6mr1150888ith.41.1528762221735; Mon, 11 Jun 2018 17:10:21 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id z143-v6sm8160855iof.57.2018.06.11.17.10.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Jun 2018 17:10:19 -0700 (PDT) In-Reply-To: <83efhgtq25.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 09 Jun 2018 09:46:42 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147307 Archived-At: --=-=-= Content-Type: text/plain tags 31764 + patch quit Eli Zaretskii writes: >> I can reproduce this on GNU/Linux, but not on Windows (both tested with >> latest emacs-26). > > Isn't that strange? The code involved isn't platform specific. Looks like a matter of timing, if I add a (sit-for 1) to beginning of vc-exec-after (or use edebug), then I can reproduce on Windows too. Adding a save-excursion seems to fix it. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v1-0001-Keep-vc-print-log-from-putting-point-at-buffer-en.patch Content-Description: patch >From 895d29eb6b010093245a67d7f05808d765195b7a Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Mon, 11 Jun 2018 20:00:54 -0400 Subject: [PATCH v1] Keep vc-print-log from putting point at buffer end (Bug#31764) * lisp/vc/vc.el (vc-print-log-internal): Use `save-excursion' around `vc-print-log-setup-buttons'. --- lisp/vc/vc.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 93e9c25cbf..41a76e0007 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -2256,8 +2256,9 @@ vc-print-log-internal (vc-call-backend bk 'print-log files-arg buf shortlog (when is-start-revision working-revision) limit)) (lambda (_bk _files-arg ret) - (vc-print-log-setup-buttons working-revision - is-start-revision limit ret)) + (save-excursion + (vc-print-log-setup-buttons working-revision + is-start-revision limit ret))) ;; When it's nil, point really shouldn't move (bug#15322). (when working-revision (lambda (bk) -- 2.11.0 --=-=-=--