From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#31760: 26.1; ruby-mode enables flymake-rubocop by default if the rubocop executable exists Date: Sat, 16 Jun 2018 16:32:21 +0100 Message-ID: <87602ihhmi.fsf@gmail.com> References: <87k1r972fp.wl-bordjukov@gmail.com> <87po11i0he.fsf@gmail.com> <83d8f202-8842-56fe-0350-5f2fa9a01d67@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1529163071 29180 195.159.176.226 (16 Jun 2018 15:31:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 16 Jun 2018 15:31:11 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Bozhidar Batsov , 31760@debbugs.gnu.org, Dmitry Gutov To: Petko Bordjukov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 16 17:31:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUDAP-0007Pl-IO for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Jun 2018 17:31:05 +0200 Original-Received: from localhost ([::1]:51857 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUDCV-0005VS-0v for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Jun 2018 11:33:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35342) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUDCO-0005VL-P1 for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2018 11:33:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fUDCJ-0004eA-RI for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2018 11:33:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43928) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fUDCJ-0004dq-M1 for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2018 11:33:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fUDCI-0004ub-3C for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2018 11:33:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Jun 2018 15:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31760 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31760-submit@debbugs.gnu.org id=B31760.152916315318845 (code B ref 31760); Sat, 16 Jun 2018 15:33:02 +0000 Original-Received: (at 31760) by debbugs.gnu.org; 16 Jun 2018 15:32:33 +0000 Original-Received: from localhost ([127.0.0.1]:51825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUDBp-0004tt-2s for submit@debbugs.gnu.org; Sat, 16 Jun 2018 11:32:33 -0400 Original-Received: from mail-wm0-f49.google.com ([74.125.82.49]:38985) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUDBn-0004tg-Ip for 31760@debbugs.gnu.org; Sat, 16 Jun 2018 11:32:31 -0400 Original-Received: by mail-wm0-f49.google.com with SMTP id p11-v6so8445766wmc.4 for <31760@debbugs.gnu.org>; Sat, 16 Jun 2018 08:32:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=jLq3liXOXeoUbQjS3EiKsCPSmQW6j/hQ3oRlXLe0lx8=; b=S6SKIAPAb5yhNqJ2DxkmYWtk8JQ8zixwUHNzN4ii8InhOqWHj8Kty3pCkHDqJG5ugE 8u8pdi/fb/GIMPfm3+Q8I0yDN2Oie8CyMoEseACgibnEECIyXFYvAkwqzU2TC6Hyl4Cv LJ9oFTvkAQHeEGKwUtFvHcrN3LA0HfdWTBOb6aWkN69C1+MJaFxoL8erYvqWxV5ktWH2 MKMN0i8ZqbJdQbzNl5zdU2A0jp3AdHk/736PqyEDSEHLE59t0l8d+Bs2Juv3ljWF1Ohm z2KBum53Jc5/PIxjRkO4oOj0q9/JeFyuZE0ld3U4NhBYAErrBT33frMBI9Boe92s2289 F9YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=jLq3liXOXeoUbQjS3EiKsCPSmQW6j/hQ3oRlXLe0lx8=; b=T2edn7VG4H/qQDMQiDRonm0LB+f5gdw/SxVr6CaA/+g3SxW6fF4/RHJZCiGJuZQdh5 RXdWKRMqtqHoW0QPq8JBrYJtuzzfw8g+5cXV7T9FO8HltcL9uyC2qyX8OLDyWjIpbJJF IfZXy+xtf0te8sSNtsZtRh8Ft5oOolOLco3gq2hPDluqnf2hb3jB3ElFKDW8pdA8Ov3d CywA+naWpE7wL+Zokup357k37nGgvIBCH5TqcRcdu3GTwQIxk3jqnyLJ5LUIq4YPthcg Rj6S7w8iITo+FiQptDZhW8A7MBQn51hCSqEHzZ9+3y8egsRwTrK2ehiLjJPUiq+QtUL8 1JHg== X-Gm-Message-State: APt69E3HgDmQBFOolKs/lsI4V3UlPQYxvMHLAbMe2eq7gtWHN5trITGG jZr7mAjuj+dKMjrI8ZHeV+xc1ytO X-Google-Smtp-Source: ADUXVKIzkas9UPuv/5j/6q9YrM6QD9RnnaODcEELZjTdSOqLDcyj//qsMO1k53oz+VhHTL/youvkCg== X-Received: by 2002:a1c:d543:: with SMTP id m64-v6mr3897322wmg.12.1529163145371; Sat, 16 Jun 2018 08:32:25 -0700 (PDT) Original-Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id n21-v6sm3015397wmc.42.2018.06.16.08.32.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 16 Jun 2018 08:32:24 -0700 (PDT) In-Reply-To: (Petko Bordjukov's message of "Sat, 16 Jun 2018 12:07:36 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147514 Archived-At: Petko Bordjukov writes: > Again, I appreciate this feature, but do not leave it on by default -- > it will be just another bad Emacs default. > I'd just like to chime in briefly with two points: * IMO Petko has a point: Emacs is expected to be conservative about tooling support: unless some optional tool is widely adopted, optional things are made... err... optional. Of course this is for some value of "widely adpted"; one that the maintainer of said tool probably has a particularly generous conception of, ehehe. There was little discussion on this before 26.1 because it was all kinda rushed, because Dmitry is the maintainer of ruby-mode, and most importantly, nobody objected (much less I, who welcomed the enthusiasm for using the new API). So even though Emacs 26.1 is a month old, the conservative stance is now to keep default. * On the practical front, I personally dislike defcustom and prefer having flymake backends separate, so instead of having ruby-flymake-auto checks the defcustom, I advise Petko to use a directory-local variable in the project configuring flymake-diagnostic-functions to either ruby-flymake-simple or ruby-flymake-rubocop, i.e. some .dir-locals.el containing this (... (ruby-mode . (... (flymake-diagnostic-functions ruby-flymake-simple) ...)) ...) =20=20 Won't this suffice as a per-project (almost zero) configuration? Jo=C3=A3o =20=20