all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Petko Bordjukov <bordjukov@gmail.com>
Cc: Bozhidar Batsov <bozhidar@batsov.com>,
	31760@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#31760: 26.1; ruby-mode enables flymake-rubocop by default if the rubocop executable exists
Date: Sat, 16 Jun 2018 16:32:21 +0100	[thread overview]
Message-ID: <87602ihhmi.fsf@gmail.com> (raw)
In-Reply-To: <CAAgmp6vm-C4JETt4T1nzPT1VCQTbyNmpRW6tS1LP_4dVeqo+MA@mail.gmail.com> (Petko Bordjukov's message of "Sat, 16 Jun 2018 12:07:36 +0300")

Petko Bordjukov <bordjukov@gmail.com> writes:

> Again, I appreciate this feature, but do not leave it on by default --
> it will be just another bad Emacs default.
>

I'd just like to chime in briefly with two points:

* IMO Petko has a point: Emacs is expected to be conservative about
  tooling support: unless some optional tool is widely adopted, optional
  things are made... err... optional.  Of course this is for some value
  of "widely adpted"; one that the maintainer of said tool probably has
  a particularly generous conception of, ehehe.

  There was little discussion on this before 26.1 because it was all
  kinda rushed, because Dmitry is the maintainer of ruby-mode, and most
  importantly, nobody objected (much less I, who welcomed the enthusiasm
  for using the new API).  So even though Emacs 26.1 is a month old, the
  conservative stance is now to keep default.

* On the practical front, I personally dislike defcustom and prefer
  having flymake backends separate, so instead of having
  ruby-flymake-auto checks the defcustom, I advise Petko to use a
  directory-local variable in the project configuring
  flymake-diagnostic-functions to either ruby-flymake-simple or
  ruby-flymake-rubocop, i.e. some .dir-locals.el containing this

     (...
      (ruby-mode . (...
                    (flymake-diagnostic-functions ruby-flymake-simple)
                    ...))
      ...)
  
  Won't this suffice as a per-project (almost zero) configuration?

João
  






  parent reply	other threads:[~2018-06-16 15:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-08 14:55 bug#31760: 26.1; ruby-mode enables flymake-rubocop by default if the rubocop executable exists Petko Bordjukov
2018-06-08 18:42 ` João Távora
2018-06-15 15:16   ` Dmitry Gutov
2018-06-15 17:54     ` Bozhidar Batsov
2018-06-16  9:07       ` Petko Bordjukov
2018-06-16  9:31         ` Bozhidar Batsov
2018-06-16  9:36           ` Bozhidar Batsov
2018-06-16 19:47             ` Petko Bordjukov
2018-06-16 19:55               ` Bozhidar Batsov
2018-06-16 15:32         ` João Távora [this message]
2018-06-16 19:54           ` Petko Bordjukov
2018-06-18 14:02           ` Dmitry Gutov
2018-06-18 14:09             ` Bozhidar Batsov
2018-12-25 15:36               ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87602ihhmi.fsf@gmail.com \
    --to=joaotavora@gmail.com \
    --cc=31760@debbugs.gnu.org \
    --cc=bordjukov@gmail.com \
    --cc=bozhidar@batsov.com \
    --cc=dgutov@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.