all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: martin rudalics <rudalics@gmx.at>
Cc: 32637@debbugs.gnu.org
Subject: bug#32637: 27.0.50; window-size-change-functions not run from local hook
Date: Sun, 09 Sep 2018 19:17:27 +0300	[thread overview]
Message-ID: <875zzewsq1.fsf@mail.linkov.net> (raw)
In-Reply-To: <5B94DC81.7090104@gmx.at> (martin rudalics's message of "Sun, 09 Sep 2018 10:40:33 +0200")

>> window-size-change-functions calling code could detect if a window with
>> a buffer-local hook changed its size, and not to call its hook in this
>> case.  This would be even better than using global hook where you can't
>> implement such optimization.
>
> Agreed.
>
>> window-size-change-functions calling code could call it only once
>> for every frame, even if the same buffer is displayed in multiple
>> windows.
>
> Agreed.
>
>> I see that it's not called when the buffer is not displayed in any
>> window on the frame - this is correct.  But what I noted earlier is that
>> it's not called when the buffer with the buffer-local hook is not the
>> current-buffer in the selected window (but it's displayed in a
>> non-selected window on the frame) - this should be fixed to call the hook
>> regardless if its window is currently selected or not.
>
> Agreed.  I attach an untested and undocumented patch.  Please have a
> look.

Thank you for the patch.  I tried it and it works without problems.
I'm testing it on the image window resizing in bug#32672
and it calls window-size-change-functions regardless if the current
buffer is in image-mode, or if the image buffer in another window.





  parent reply	other threads:[~2018-09-09 16:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-04 21:03 bug#32637: 27.0.50; window-size-change-functions not run from local hook Juri Linkov
2018-09-05  7:47 ` martin rudalics
2018-09-05 15:26   ` Eli Zaretskii
2018-09-05 21:56     ` Juri Linkov
2018-09-06  2:35       ` Eli Zaretskii
2018-09-06 22:17         ` Juri Linkov
2018-09-05 21:54   ` Juri Linkov
2018-09-06  7:05     ` martin rudalics
2018-09-06 22:06       ` Juri Linkov
2018-09-07  7:31         ` martin rudalics
2018-09-08 23:56           ` Juri Linkov
2018-09-09  6:03             ` Eli Zaretskii
2018-09-09  8:40             ` martin rudalics
2018-09-09 15:59               ` Eli Zaretskii
2018-09-10  8:29                 ` martin rudalics
2018-09-09 16:17               ` Juri Linkov [this message]
2018-09-10  8:29                 ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875zzewsq1.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=32637@debbugs.gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.