From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#33665: 27.0.50; Variables not set up in Gnus when hooks are run Date: Fri, 07 Dec 2018 09:25:21 -0800 Message-ID: <875zw5xn9a.fsf@ericabrahamsen.net> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1544203513 7015 195.159.176.226 (7 Dec 2018 17:25:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 7 Dec 2018 17:25:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 33665@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 07 18:25:08 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVJsC-0001i2-7w for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Dec 2018 18:25:08 +0100 Original-Received: from localhost ([::1]:47456 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gVJuI-0001zn-KQ for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Dec 2018 12:27:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38452) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gVJtB-0001Gk-2K for bug-gnu-emacs@gnu.org; Fri, 07 Dec 2018 12:26:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gVJt7-00065D-Ay for bug-gnu-emacs@gnu.org; Fri, 07 Dec 2018 12:26:09 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:32991) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gVJt4-000648-Jn for bug-gnu-emacs@gnu.org; Fri, 07 Dec 2018 12:26:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gVJt4-0000Lj-Dp for bug-gnu-emacs@gnu.org; Fri, 07 Dec 2018 12:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Dec 2018 17:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33665 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33665-submit@debbugs.gnu.org id=B33665.15442035311301 (code B ref 33665); Fri, 07 Dec 2018 17:26:02 +0000 Original-Received: (at 33665) by debbugs.gnu.org; 7 Dec 2018 17:25:31 +0000 Original-Received: from localhost ([127.0.0.1]:37249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVJsV-0000Kr-I1 for submit@debbugs.gnu.org; Fri, 07 Dec 2018 12:25:31 -0500 Original-Received: from mail.ericabrahamsen.net ([50.56.99.223]:50477) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVJsQ-0000Kg-LM for 33665@debbugs.gnu.org; Fri, 07 Dec 2018 12:25:26 -0500 Original-Received: from localhost (71-212-20-199.tukw.qwest.net [71.212.20.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id EE0013F09A; Fri, 7 Dec 2018 17:25:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1544203522; bh=IwlRnz2v0VY9J0wQDpcGg0Z8Oze01pkQXRw5f03mC9M=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=NXDwkWbNkexTNfhGQ96l6Gz8F2kpU/gaK5pXEF5n0o+Z/O2UHtmXmhFQy6VkY+q3k sfQQzujraRDDNnldUz3h/kYcxJFvgBsjbVrmc/wsK9YMd9wFnhOG+jV9Kl7kge/4BK RzQCciLi8Tg+sGwQVBg+p5C6LA9lrOZIawFAo8G4= In-Reply-To: (Lars Ingebrigtsen's message of "Fri, 07 Dec 2018 17:37:11 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153183 Archived-At: Lars Ingebrigtsen writes: > It looks like gnus-newsgroup-name (and friends?) are no longer set when > the summary mode hooks are run, so hooks that rely on that are now > broken. Yes, since `gnus-summary-mode' is now a real mode, it clears local variables before running the hook. The right place for that sort of hook is now `gnus-summary-prepared-hook'. I tried to change all the relevant hooks I could within the codebase, but I guess gnus-mdrtn.el isn't publicly available? I can change the Moderation section of the manual to update the installation instructions. > It also looks like summary mode line highlights no longer works. I'll take a look now.