From: Juri Linkov <juri@linkov.net>
To: 33838@debbugs.gnu.org
Subject: bug#33838: 27.0.50; lazy-highlight fails with a quick key sequence
Date: Mon, 24 Dec 2018 01:27:22 +0200 [thread overview]
Message-ID: <875zvjn7s5.fsf@mail.linkov.net> (raw)
In-Reply-To: <87muox3y68.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 23 Dec 2018 02:05:19 +0200")
> Quickly typing `C-s C-s' to repeat the last search in a file with long
> wrapped lines sometimes fails to lazy-highlight other matches.
>
> This is because the condition in isearch-lazy-highlight-new-loop relies on
> the return value of `(sit-for 0)' and when there is input pending like the
> second `C-s' keystroke unprocessed due to the large file size with long
> lines, it doesn't start a new lazy-highlight loop.
I realized that sit-for here is for a reason to not try running
isearch-lazy-highlight-new-loop on every keypress. The problem is that
when the first `C-s' is ignored (in this case isearch-string is an empty
string and isearch-lazy-highlight-last-string is the last search string),
for the second `C-s', isearch-string is equal to isearch-lazy-highlight-last-string
from the last search, so a new loop is not initiated.
A proper fix would be to reset isearch-lazy-highlight-last-string
on exiting Isearch, so it won't affect the next search:
diff --git a/lisp/isearch.el b/lisp/isearch.el
index dd0973d4ea..d2c1c150b5 100644
--- a/lisp/isearch.el
+++ b/lisp/isearch.el
@@ -1357,6 +1357,7 @@ isearch-done
(setq minibuffer-message-timeout isearch-original-minibuffer-message-timeout)
(isearch-dehighlight)
(lazy-highlight-cleanup lazy-highlight-cleanup)
+ (setq isearch-lazy-highlight-last-string nil)
(let ((found-start (window-group-start))
(found-point (point)))
(when isearch-window-configuration
next prev parent reply other threads:[~2018-12-23 23:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-23 0:05 bug#33838: 27.0.50; lazy-highlight fails with a quick key sequence Juri Linkov
2018-12-23 23:27 ` Juri Linkov [this message]
2018-12-25 21:54 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zvjn7s5.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=33838@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.