From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: Core ELPA was: Testing fontification, indentation, and buffer manipulation Date: Sat, 02 Mar 2019 11:14:06 +0000 Message-ID: <875zt15y0x.fsf@russet.org.uk> References: <7803c5de-e139-01ed-e9e3-98abb875782b@grinta.net> <2d777e7b-28d9-36a5-073d-b439fca9706a@grinta.net> <1548067539.3478998.1639830432.03003247@webmail.messagingengine.com> <87bm47558t.fsf@russet.org.uk> <87pnsm2vsm.fsf@russet.org.uk> <878sz7u2f5.fsf@russet.org.uk> <87o976p6xt.fsf_-_@russet.org.uk> <87tvgm7fnu.fsf@russet.org.uk> <87sgw6i89k.fsf@russet.org.uk> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="132461"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 02 12:14:24 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h02b1-000Y8s-MZ for ged-emacs-devel@m.gmane.org; Sat, 02 Mar 2019 12:14:23 +0100 Original-Received: from localhost ([127.0.0.1]:52738 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h02b0-0002nN-Kl for ged-emacs-devel@m.gmane.org; Sat, 02 Mar 2019 06:14:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h02ao-0002mO-TL for emacs-devel@gnu.org; Sat, 02 Mar 2019 06:14:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h02ao-0005lm-2h for emacs-devel@gnu.org; Sat, 02 Mar 2019 06:14:10 -0500 Original-Received: from cloud103.planethippo.com ([78.129.138.110]:41098) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h02an-0005iq-K2 for emacs-devel@gnu.org; Sat, 02 Mar 2019 06:14:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=H78yvLkFkZuDKM9GqzOumHYJVxRs6K/w3Wii7WN0RK8=; b=hHnPYZjy4y9YGZVqjyag/QL2R LmTY2n0Xf9qcfl1BDeg0SujaloJIi5yEINoSb5UAtG3KR8u/KGlV1BDtO/45WUpBhycNWxKm1/dlA lRxpmd/78RO1nTFDqG7Jw5JOFHZEtmeTGqr4mYZv11NC3/ftJrKCnAPlJ5MPmWjXUfpYVjPBCFmMQ oBgpWrWBv0HGAqLSWFFQSvkR0FM3K1IDtNWttDT2lwjS9nlKXTFRfl51nbMw/caBmRE5L5oURe72g ZxCVE7mHOrBCSX8afIs7eEm4L7LsVnKhoj2T5n9Fw3DA9LftsH8D6TzDnA7ODj7DKdw6UOta5DkVA HGABSyT3A==; Original-Received: from cpc142652-benw12-2-0-cust953.16-2.cable.virginm.net ([82.21.43.186]:58302 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h02ak-0000lr-R8; Sat, 02 Mar 2019 11:14:06 +0000 In-Reply-To: (Stefan Monnier's message of "Fri, 01 Mar 2019 17:07:10 -0500") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 78.129.138.110 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233757 Archived-At: Stefan Monnier writes: >> I could move the dependency to Makefile.in I guess? Then a simple >> ./configure wouldn't change things, but any textual change in >> Makefile.in would. Or, I could check the repo for the SHA-1 first and if >> this doesn't exist, the run git fetch. > > My opinion is that the problem in in having the SHAs in Makefile.in. > I think Makefile.in should refer to branches/tags rather than to SHAs. I thought about that. Actually, the code would cope with branches and tags, but I think they are both a bad idea. The problem with branches is that what is on the branch changes. My feeling is that the build process should be repeatable; so building emacs-27.1-with-elpa.tgz should not result in different tar balls as ELPA changes. The problem with tags is that with ELPA as a single git, tags share a single namespace. Otherwise, people could just add "emacs-27.1" or whatever to say which version of the package should be for Emacs-27.1. But this would require all ELPA packages on master to choose the same point in time for a release and would not work at all for packages on a branch. Finally, neither solve the problem -- if a branch or tag is add EMACS/elpa/Makefile.in which exists in the ELPA repo, but not in the clone on the local machine the build will fail. > PS: Also, every time Makefile.in changes, `make` re-runs config.status > which then causes all the .o files to be recompiled as well, so I'd > rather we don't change it all too often. Oh, yes, that's true. Putting those eval calls into the Makefile is pretty ugly. I can move the SHA data out into a secondary file no worries. Phil