From: phillip.lord@russet.org.uk (Phillip Lord)
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Core ELPA was: Testing fontification, indentation, and buffer manipulation
Date: Sat, 02 Mar 2019 11:14:06 +0000 [thread overview]
Message-ID: <875zt15y0x.fsf@russet.org.uk> (raw)
In-Reply-To: <jwv8sxyqmkb.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 01 Mar 2019 17:07:10 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> I could move the dependency to Makefile.in I guess? Then a simple
>> ./configure wouldn't change things, but any textual change in
>> Makefile.in would. Or, I could check the repo for the SHA-1 first and if
>> this doesn't exist, the run git fetch.
>
> My opinion is that the problem in in having the SHAs in Makefile.in.
> I think Makefile.in should refer to branches/tags rather than to SHAs.
I thought about that. Actually, the code would cope with branches and
tags, but I think they are both a bad idea.
The problem with branches is that what is on the branch changes. My
feeling is that the build process should be repeatable; so building
emacs-27.1-with-elpa.tgz should not result in different tar balls as
ELPA changes.
The problem with tags is that with ELPA as a single git, tags share a
single namespace. Otherwise, people could just add "emacs-27.1" or
whatever to say which version of the package should be for
Emacs-27.1. But this would require all ELPA packages on master to
choose the same point in time for a release and would not work at all
for packages on a branch.
Finally, neither solve the problem -- if a branch or tag is add
EMACS/elpa/Makefile.in which exists in the ELPA repo, but not in the
clone on the local machine the build will fail.
> PS: Also, every time Makefile.in changes, `make` re-runs config.status
> which then causes all the .o files to be recompiled as well, so I'd
> rather we don't change it all too often.
Oh, yes, that's true. Putting those eval calls into the Makefile is
pretty ugly. I can move the SHA data out into a secondary file no
worries.
Phil
next prev parent reply other threads:[~2019-03-02 11:14 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 15:43 Testing fontification, indentation, and buffer manipulation Daniele Nicolodi
2019-01-15 18:45 ` Yuri Khan
2019-01-19 15:07 ` Daniele Nicolodi
2019-01-21 10:45 ` Jostein Kjønigsen
2019-01-21 20:57 ` Richard Stallman
2019-01-23 23:22 ` Phillip Lord
2019-01-24 2:09 ` Stefan Monnier
2019-01-24 10:29 ` Phillip Lord
2019-01-24 14:48 ` Ted Zlatanov
2019-01-26 0:46 ` Stefan Monnier
2019-01-26 7:17 ` Eli Zaretskii
2019-01-26 10:41 ` Phillip Lord
2019-02-20 19:59 ` Core ELPA was: " Phillip Lord
2019-02-27 23:05 ` Stefan Monnier
2019-03-01 15:55 ` Phillip Lord
2019-03-01 17:25 ` Stefan Monnier
2019-03-01 21:39 ` Phillip Lord
2019-03-01 22:07 ` Stefan Monnier
2019-03-02 11:14 ` Phillip Lord [this message]
2019-03-03 3:23 ` Stefan Monnier
2019-03-03 18:06 ` Phillip Lord
2019-03-08 2:51 ` Stefan Monnier
2019-03-10 11:45 ` Phillip Lord
2019-03-10 18:02 ` Stefan Monnier
2019-03-11 22:46 ` Phillip Lord
2019-03-12 1:11 ` Stefan Monnier
2019-03-12 23:02 ` Phillip Lord
2019-03-13 19:05 ` Stefan Monnier
2019-03-13 22:41 ` Phillip Lord
2019-03-02 3:36 ` Richard Stallman
2019-03-02 11:21 ` Phillip Lord
2019-03-03 3:00 ` Richard Stallman
2019-03-03 17:52 ` Phillip Lord
2019-03-04 3:27 ` Richard Stallman
2019-03-10 11:27 ` Phillip Lord
2019-03-11 1:23 ` Richard Stallman
2019-03-11 22:08 ` Phillip Lord
2019-03-12 3:38 ` Richard Stallman
2019-03-12 15:42 ` Eli Zaretskii
2019-03-12 15:52 ` Robert Pluim
2019-03-12 17:25 ` Eli Zaretskii
2019-03-12 22:49 ` Phillip Lord
2019-03-12 22:48 ` Phillip Lord
2019-03-12 18:37 ` XEmacs packages (was: Core ELPA was: Testing fontification, indentation, and buffer manipulation) Stefan Monnier
2019-03-13 3:32 ` Core ELPA was: Testing fontification, indentation, and buffer manipulation Richard Stallman
2019-01-16 7:58 ` Helmut Eller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zt15y0x.fsf@russet.org.uk \
--to=phillip.lord@russet.org.uk \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.